Skip to content

Use installed CMake configs for dependencies#3213

Open
darkdragon-001 wants to merge 4 commits into
google:masterfrom
darkdragon-001:find-protobuf
Open

Use installed CMake configs for dependencies#3213
darkdragon-001 wants to merge 4 commits into
google:masterfrom
darkdragon-001:find-protobuf

Conversation

@darkdragon-001

Copy link
Copy Markdown
Contributor
  • Use find_package(absl CONFIG) as there is no built-in CMake module for absl
  • Use find_package(Protobuf CONFIG) as the built-in CMake module doesn't propagate it's absl dependency correctly
  • Use CMake targets instead of variables to automatically propagate include directories directly
  • Use shipped generate_protobuf() function instead of custom command

@darkdragon-001 darkdragon-001 requested a review from a team as a code owner September 9, 2023 15:17
@lonnieashley72

lonnieashley72 commented Sep 9, 2023 via email

Copy link
Copy Markdown

nephros pushed a commit to nephros/libphonenumber that referenced this pull request Dec 9, 2023
nephros pushed a commit to nephros/libphonenumber that referenced this pull request Dec 9, 2023
nephros pushed a commit to nephros/libphonenumber that referenced this pull request Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants