Load metadata from file#3185
Open
dponomarenko-firstorion wants to merge 6 commits into
Open
Conversation
katbohm
reviewed
Nov 16, 2023
katbohm
left a comment
Contributor
There was a problem hiding this comment.
Hi there!
Thank you for your pull request and contributing to the LibPhoneNumber library.
As for the proposed changes, I think the functionality might be useful. My main note is that I think the two binary *.dat files shouldn't be checked in, but rather generated by build rules.
Author
|
Hello @katbohm @kkeshava and @tvislavski! |
|
Hello @katbohm @kkeshava and @tvislavski, Is there anything else needed for this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to propose to add one more metadata loading mechanism for libphonenumber cpp version , which would load metadata from protobuf binary file.
This functionality is desired by developers, as it eliminates the need to rebuild and release new libphonenumber version when only data update is required.
I am proposing to add compile-time switch to differentiate between data loading from binary array and data loading from protobuf binary file.
Also new public function “bool ReloadMetadata(const string& filepath) added to PhoneNumberUtil class intended to provide ability to reload metadata without restarting client application process. Here is what ReloadMetadata will do :
@kkeshava @katbohm