Skip to content

chore: Simplify generate.sh by removing git worktree and using generator-based check #4120

Open
Not-Dhananjay-Mishra wants to merge 5 commits intogoogle:masterfrom
Not-Dhananjay-Mishra:gen-improvement
Open

chore: Simplify generate.sh by removing git worktree and using generator-based check #4120
Not-Dhananjay-Mishra wants to merge 5 commits intogoogle:masterfrom
Not-Dhananjay-Mishra:gen-improvement

Conversation

@Not-Dhananjay-Mishra
Copy link
Contributor

Added -check (env-driven via CHECK=1) support to:

  • gen-accessors.go
  • gen-iterators.go
  • gen-stringify-test.go

Simplified script/generate.sh to:

  • run go generate ./...
  • optionally enable check mode via CHECK=1

Related : #3983

@codecov
Copy link

codecov bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.71%. Comparing base (88c87d1) to head (d1e963c).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4120   +/-   ##
=======================================
  Coverage   93.71%   93.71%           
=======================================
  Files         211      211           
  Lines       19614    19614           
=======================================
  Hits        18382    18382           
  Misses       1034     1034           
  Partials      198      198           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@alexandear alexandear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants