Skip to content

Conversation

@alexandear
Copy link
Contributor

@alexandear alexandear commented Jan 29, 2026

./script/lint.sh now works in Git Bash on Windows. Tested on a virtual machine with Windows 11 installed. This should improve the developer experience for contributors who don't use Windows Subsystem for Linux.

VS Code on Windows

Before we have an issue:

$ ./script/lint.sh 
linting .
0 issues.
linting example
linting example
0 issues.
linting scrape
0 issues.
linting tools
0 issues.
linting tools/fmtpercentv
0 issues.
linting tools/sliceofpointers
0 issues.
linting tools/structfield
0 issues.
validating generated files
github\github.go:8: running "../script/metadata.sh": fork/exec ../script/metadata.sh: %1 is not a valid Win32 application.
failed validating generated files

Inspired by discussion comments in #3938.

@merchantmoh-debug
Copy link
Contributor

@alexandear - My Hero!

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.45%. Comparing base (1c42933) to head (db98fcb).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3950   +/-   ##
=======================================
  Coverage   92.45%   92.45%           
=======================================
  Files         203      203           
  Lines       14980    14980           
=======================================
  Hits        13850    13850           
  Misses        927      927           
  Partials      203      203           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis gmlewis changed the title chore: Adapt lint.sh to Windows Git Bash chore: Adapt lint.sh to Windows Git Bash Jan 30, 2026
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alexandear!
LGTM.
Merging.

@gmlewis gmlewis merged commit 0566d1e into google:master Jan 30, 2026
8 checks passed
@alexandear alexandear deleted the chore/adapt-windows-git-bash branch January 30, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants