-
Notifications
You must be signed in to change notification settings - Fork 2.2k
chore: Use example.com instead of random URLs in tests
#3948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@gmlewis Should I update them too? This test contain some download URLs go-github/github/actions_runners_test.go Lines 33 to 38 in 1c42933
The URL present in this test go-github/github/admin_users_test.go Lines 124 to 128 in 1c42933
The URLs present in this test Lines 28 to 50 in 1c42933
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3948 +/- ##
=======================================
Coverage 92.45% 92.45%
=======================================
Files 203 203
Lines 14980 14980
=======================================
Hits 13850 13850
Misses 927 927
Partials 203 203 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
example.com instead of random URLs in testexample.com instead of random URLs in tests
|
@Not-Dhananjay-Mishra - I think that IP addresses (since there is no particular reason to use IP addresses in this case that I can tell) can be changed to example.com and so can git.company.com. Thanks. |
For reference : comment