docs: Update readme and examples for updated go-github-ratelimit and introduce go-github-pagination#3504
Conversation
example/go.mod
Outdated
| go 1.23.1 | ||
|
|
||
| toolchain go1.23.5 |
There was a problem hiding this comment.
These changes will have to wait until be bump the Go toolchain for the entire repo.
There was a problem hiding this comment.
OK, please delete lines 4 and 5 and merge in the latest changes from the master branch which should make line 3 say go 1.23.0 and then we should be good to go.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3504 +/- ##
==========================================
+ Coverage 91.21% 91.25% +0.03%
==========================================
Files 182 183 +1
Lines 15930 16058 +128
==========================================
+ Hits 14531 14654 +123
- Misses 1225 1230 +5
Partials 174 174 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@gmlewis |
…introduce go-github-pagination
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
example/go.mod
Outdated
| module github.com/google/go-github/v69/example | ||
|
|
||
| go 1.23.0 | ||
| go 1.23.1 |
There was a problem hiding this comment.
Doesn't this work with go 1.23.0 ?
We would prefer to use that due to #3423 (comment)
There was a problem hiding this comment.
no problem at all, fixed.
I just misunderstood your previous comment to mean that you want line 3 to remain.
Is there any way that your package could change its requirements to |
|
There's a long thread in #3423 that describes why this is beneficial. |
Sure, I don't mind at all. I'll push a new tag and update this branch accordingly.
huh thanks for sharing that info. |
|
@gmlewis done! let me know if you need me to fix anything else. |
It looks like the linter is requiring |
|
@gmlewis |
|
In the future, please don't force push PRs in this repo as it blows away previous review history. |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @gofri!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
@stevehipwell - might you have time for a code review? Thank you!
|
Thank you, @stevehipwell! |
Closes: #2618.
Hey,
Opened this PR following the v2 release of go-github-ratelimit (🥳) that supports primary rate limits handling,
as well as the releaes of go-github-pagination as mentioned in #2618.
This PR only touches the main README file and the examples.