This repository was archived by the owner on Apr 18, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
force set all items to adapter when wrap_content is set to RV, issues… #507
Open
pana777
wants to merge
1
commit into
google:main
Choose a base branch
from
pana777:bug-fix-recyclerview-show-all-items-wrap-content
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -182,6 +182,14 @@ public class FlexboxLayoutManager extends RecyclerView.LayoutManager implements | |
| /** The reference to the parent of the RecyclerView */ | ||
| private View mParent; | ||
|
|
||
| /** | ||
| * if mFillAllItemsForced == true fixes all issues with "not all items displayed when wrap_content" | ||
| * issues: #349 #336 #339 | ||
| */ | ||
| private Boolean mSetAllItemsForced = false; | ||
|
|
||
|
|
||
|
|
||
| /** | ||
| * Indicates the position that the view position that the flex line which has the view having | ||
| * this position needs to be recomputed before the next layout. | ||
|
|
@@ -312,6 +320,14 @@ public void setFlexWrap(@FlexWrap int flexWrap) { | |
| } | ||
| } | ||
|
|
||
| public Boolean getmSetAllItemsForced() { | ||
| return mSetAllItemsForced; | ||
| } | ||
|
|
||
| public void setmSetAllItemsForced(Boolean mSetAllItemsForced) { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above, naming needs correction. |
||
| this.mSetAllItemsForced = mSetAllItemsForced; | ||
| } | ||
|
|
||
| @JustifyContent | ||
| @Override | ||
| public int getJustifyContent() { | ||
|
|
@@ -874,7 +890,8 @@ private void updateFlexLines(int childCount) { | |
| // passed as 0 from the RecyclerView) | ||
| // Set the upper limit as the height of the device in order to prevent computing all | ||
| // items in the adapter | ||
| needsToFill = mLayoutState.mInfinite ? | ||
| // or set the mSetAllItemsForced to true to force all items to show | ||
| needsToFill = mSetAllItemsForced ? 999999999 : mLayoutState.mInfinite ? | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe instead this 999999999 let's put Integer.MAX_VALUE ? |
||
| mContext.getResources().getDisplayMetrics().heightPixels | ||
| : mLayoutState.mAvailable; | ||
| } else { | ||
|
|
@@ -885,7 +902,8 @@ private void updateFlexLines(int childCount) { | |
| // passed as 0 from the RecyclerView) | ||
| // Set the upper limit as the width of the device in order to prevent computing all | ||
| // items in the adapter | ||
| needsToFill = mLayoutState.mInfinite ? | ||
| // or set the mSetAllItemsForced to true to force all items to show | ||
| needsToFill = mSetAllItemsForced ? 999999999 : mLayoutState.mInfinite ? | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe instead this 999999999 let's put Integer.MAX_VALUE ? |
||
| mContext.getResources().getDisplayMetrics().widthPixels | ||
| : mLayoutState.mAvailable; | ||
| } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better would be to have it here
areAllItemsForced()or something similar.