Improve crash messages for fixes that don't apply#5533
Merged
copybara-service[bot] merged 1 commit intomasterfrom Feb 24, 2026
Merged
Improve crash messages for fixes that don't apply#5533copybara-service[bot] merged 1 commit intomasterfrom
copybara-service[bot] merged 1 commit intomasterfrom
Conversation
copybara-service
bot
force-pushed
the
test_873381734
branch
3 times, most recently
from
df1184f to
4be3e55
Compare
If a fix refers to an AST node without an end position (like `var`), report a crash at the start position for the fix, instead of at the top level of the compilation unit. This will improve failure messages for cases like #5522 PiperOrigin-RevId: 874646657
copybara-service
bot
force-pushed
the
test_873381734
branch
from
4be3e55 to
ab81681
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve crash messages for fixes that don't apply
If a fix refers to an AST node without an end position (like
var), report a crash at the start position for the fix, instead of at the top level of the compilation unit.This will improve failure messages for cases like #5522