[UnusedMethod] Handle reflective method references#5525
Open
electrum wants to merge 1 commit intogoogle:masterfrom
Open
[UnusedMethod] Handle reflective method references#5525electrum wants to merge 1 commit intogoogle:masterfrom
electrum wants to merge 1 commit intogoogle:masterfrom
Conversation
electrum
force-pushed
the
unusedmethod
branch
2 times, most recently
from
1a422d3 to
1371a8b
Compare
Handles Class.getMethod, getDeclaredMethod, getConstructor, getDeclaredConstructor, and MethodHandles.Lookup.findStatic, findVirtual, findSpecial, findConstructor. Only suppresses findings when the method name, owner class, and parameter types can all be statically resolved.
electrum
force-pushed
the
unusedmethod
branch
from
1371a8b to
27884db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handles
Class.getMethod,getDeclaredMethod,getConstructor,getDeclaredConstructor, andMethodHandles.Lookup.findStatic,findVirtual,findSpecial,findConstructor. Only suppresses findings when the method name, owner class, and parameter types can all be statically resolved.This is cleaner than adding
@Keepeverywhere, and avoids the problem that methods with@Keepcan later become unused. IntelliJ IDEA understands static reflection as method usage, and this gives Error Prone the same ability.