Refactor ComponentRequirement to compute NullPolicy at creation time.
#5067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ime. The `NullPolicy` for each `ComponentRequirement` kind is now determined when the requirement is created, rather than being computed lazily within the `nullPolicy()` method. This removes the need for an `overrideNullPolicy()` field and makes the overall logic for determining the `NullPolicy` clearer. RELNOTES=N/A PiperOrigin-RevId: 846813018
copybara-service
bot
force-pushed
the
test_846785987
branch
from
4e9033e to
54af480
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
ComponentRequirementto computeNullPolicyat creation time.The
NullPolicyfor eachComponentRequirementkind is now determined when the requirement is created, rather than being computed lazily within thenullPolicy()method.This removes the need for an
overrideNullPolicy()field and makes the overall logic for determining theNullPolicyclearer.RELNOTES=N/A