WIP: simplify recursive planning limit checks.#1900
Open
copybara-service[bot] wants to merge 1 commit intomasterfrom
Open
WIP: simplify recursive planning limit checks.#1900copybara-service[bot] wants to merge 1 commit intomasterfrom
copybara-service[bot] wants to merge 1 commit intomasterfrom
Conversation
Instead of planning recursively up to the limit, the behavior now is to check if the AST is small enough to fit in the limit and either fail or swap back to the stack machine implementation This simplifies the planner logic step and avoids some unpredictable behavior around wrapping recursive sub-programs in stack machine steps. PiperOrigin-RevId: 878154486
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP: simplify recursive planning limit checks.
Instead of planning recursively up to the limit, the behavior now is to check if the AST is small enough to fit in the limit and either fail or swap back to the stack machine implementation
This simplifies the planner logic step and avoids some unpredictable behavior around wrapping recursive sub-programs in stack machine steps.