feat: Implement TDX/SEV-SNP device support and finalize resource sharing#4
Merged
jimmychiuuuu merged 3 commits intogoogle:mainfrom Jan 15, 2026
Merged
feat: Implement TDX/SEV-SNP device support and finalize resource sharing#4jimmychiuuuu merged 3 commits intogoogle:mainfrom
jimmychiuuuu merged 3 commits intogoogle:mainfrom
Conversation
…E2E verification.
kongoshuu
reviewed
Dec 10, 2025
Collaborator
kongoshuu
left a comment
There was a problem hiding this comment.
Thanks Jimmy! This is a great PR! I took a first pass, will need to take another deep look, but just sending out for now to make sure I understand the code.
kongoshuu
previously approved these changes
Jan 6, 2026
Collaborator
Author
|
Hi @kongoshuu, thank you for the approval! I've added a final commit to refine the CI workflow and address some existing linting issues (e.g., errcheck, gofmt). I also expanded the test scope to ./... to ensure full coverage. Once the maintainer approves the workflow run, the checks should pass successfully. Thank you so much! |
kongoshuu
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements support for Intel TDX and AMD SEV-SNP confidential computing devices, refactoring the plugin into a robust, multi-resource architecture. It also corrects the resource allocation logic for vTPM to ensure proper sharing.
Key Changes
Verification
Unit Tests: All passed (go test -v ./deviceplugin/...).
E2E Validation (on GKE Confidential Nodes):
Discovery: Validated kubectl get nodes reports intel.com/tdx: 1, amd.com/sev-snp: 1, and google.com/cc: 256.
Allocation: Deployed test pods (pod-tdx.yaml, pod-snp.yaml) and verified successful injection of /dev/tdx_guest and /dev/sev-guest.
Resilience: Manually deleted the device plugin pod; confirmed that running workloads remained healthy (0 restarts).