Avoid repeated ASLR re-exec attempts#2193
Open
kiwigitops wants to merge 1 commit into
Open
Conversation
LebedevRI
reviewed
May 20, 2026
|
|
||
| // Some security profiles clear ADDR_NO_RANDOMIZE across exec even though the | ||
| // personality appears updated here. Avoid re-entering forever in that case. | ||
| static const char kAslrReexecEnv[] = "BENCHMARK_ASLR_NO_REEXEC"; |
Collaborator
There was a problem hiding this comment.
Why is this an array of strings if we only need a single string?
kiwigitops
force-pushed
the
fix-aslr-reexec-loop
branch
from
a593ebd to
eacc9ca
Compare
Author
|
Updated to use a constexpr const char* for the env var name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
This addresses the AppArmor case from #2184 where
personality()reportsADDR_NO_RANDOMIZEas set beforeexecv(), but the new process image loses that flag and re-enters the same code path forever.Testing
git diff --checkI did not add a direct unit test because the behavior depends on Linux exec/personality interaction under an AppArmor-constrained process tree.