Open
Conversation
Since CF migrated to 64 bit U-boot we can use amd64 Grub. Test: booted openwrt/debian useing amd64 Grub Bug: 463968791 Signed-off-by: Dmitrii Merkurev <dimorinny@google.com>
Databean
approved these changes
Feb 23, 2026
Comment on lines
-57
to
-58
| // NOTE: For now, just ignore the 32-bit ARM version, as Debian doesn't | ||
| // build an EFI monolith for this architecture. |
Member
There was a problem hiding this comment.
Since the reference to 32-bit arm is being removed, is that officially considered irrelevant?
Comment on lines
+154
to
161
| const auto x64_modules = | ||
| std::string(kGrubModulesPath) + std::string(kGrubModulesX64Name); | ||
| const auto modules_presented = std::all_of( | ||
| kGrubModulesX86.begin(), kGrubModulesX86.end(), | ||
| [&](const std::string& m) { return FileExists(x86_modules + m); }); | ||
| kGrubModules.begin(), kGrubModules.end(), | ||
| [&](const std::string& m) { return FileExists(x64_modules + m); }); | ||
| if (modules_presented) { | ||
| return true; | ||
| } |
Member
There was a problem hiding this comment.
This could be written as
for (std::string_view module_name : kGrubModules) {
const std::string path = absl::StrCat(kGrubModulesPath, kGrubModulesX64Name, module_name);
if (!FileExists(path)) {
return FileExists(kBootSrcPathX64);
}
}
return true;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since CF migrated to 64 bit U-boot we can use amd64 Grub.
Test: booted openwrt/debian useing amd64 Grub
Bug: 463968791