ci: add release-please automation with versioned branch workflow#51
ci: add release-please automation with versioned branch workflow#51Jacksunwei wants to merge 1 commit intomainfrom
Conversation
Summary of ChangesHello @Jacksunwei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes a comprehensive continuous integration and delivery pipeline designed to streamline the release process for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces release-please automation for managing Python package releases. The configuration is well-structured and follows a versioned branch workflow, which is a great strategy. I've made one suggestion to use a more idiomatic configuration option in the release-please-config.json file to improve clarity. Otherwise, the changes look good.
.github/release-please-config.json
Outdated
| "extra-files": [ | ||
| "src/google/adk_community/version.py" | ||
| ], |
There was a problem hiding this comment.
For the python release type, it's more idiomatic to use the version_file property to specify the file containing the version string. While extra-files works, version_file is more specific to the Python release strategy and makes the configuration clearer about its intent to update the Python package version.
"version_file": "src/google/adk_community/version.py",- Add release-please config with draft releases and changelog sections - Add cut-release-branch workflow: creates branch, bumps version, builds wheel - Add release-please workflow: creates CHANGELOG PR, uses version from branch name - Add publish-pypi workflow: publishes to PyPI when draft release is published Release flow: 1. Run "Cut Release Branch" with version → builds wheel for testing 2. Release-please creates CHANGELOG PR for review 3. Merge PR → draft release created 4. Publish draft → PyPI publish triggered
de75397 to
2e40acd
Compare
Summary
release/vX.Y.Z) to avoid blocking main during release prepFiles Added
.github/release-please-config.json- Release-please configuration with draft releases.github/.release-please-manifest.json- Version tracking (starting at 0.2.0).github/workflows/cut-release-branch.yml- Creates release branch, bumps version, builds wheel.github/workflows/release-please.yml- Creates CHANGELOG PR, draft release when merged.github/workflows/publish-pypi.yml- Publishes to PyPI when draft is publishedRelease Workflow
0.3.0)release/v0.3.0branchversion.pyand manifestchore: release X.Y.ZRequirements
PYPI_TOKENsecret for PyPI publishing