feat: Add S3 support for artifacts

[wmsnp]

Link to Issue or Description of Change

• Closes: Add S3 support to manage artifacts. adk-python#555
• Related:
  • feat: Add S3 support for artifacts adk-python#556
  • feat: Add S3 support for artifacts adk-python#3563

Description

Introduce S3ArtifactService to provide an self-hosted Artifact storage solution

Solution

• Supports asynchronous upload and download of S3 artifacts
• Includes unit tests covering core functionality
• Depends on aioboto3

Testing Plan

• I have added or updated unit tests for my change.
• All unit tests pass locally.

[gemini-code-assist]

Summary of Changes

Hello @wmsnp, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the artifact storage capabilities by integrating S3-compatible object storage. It provides a robust, self-hosted option for managing application artifacts, ensuring data persistence and version control. The new service is designed for high performance through asynchronous operations and includes comprehensive testing to guarantee reliability.

Highlights

• S3 Artifact Service Introduction: Introduced a new S3ArtifactService class to provide a self-hosted solution for storing and retrieving artifacts using Amazon S3 or S3-compatible services.
• Asynchronous Operations: The S3ArtifactService supports asynchronous upload and download of artifacts, leveraging aioboto3 for non-blocking I/O operations.
• Artifact Versioning and Metadata: Implemented atomic versioning for artifacts using S3's If-None-Match header, along with support for custom metadata which is JSON-serialized.
• Comprehensive Unit Tests: Added a new test file with extensive unit tests covering the core functionality of the S3ArtifactService, including saving, loading, deleting, and listing artifacts and their versions, as well as handling user-scoped artifacts.
• Dependency Update: Added aioboto3>=15.5.0 as a new dependency to pyproject.toml to enable asynchronous interaction with S3.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces an S3ArtifactService to support artifact storage on S3-compatible services. The implementation is robust, featuring asynchronous operations and atomic versioning with a retry mechanism. The accompanying unit tests are comprehensive and effectively mock the S3 interactions. I've identified a few areas for improvement, including a performance optimization for listing artifact versions, adding a test case for the version conflict retry logic, and some minor code cleanup in the project dependencies and tests. Overall, this is a solid contribution.