Skip to content

Add WASM RELAXED-SIMD F32 RMINMAX microkernels#9940

Merged
copybara-service[bot] merged 1 commit intogoogle:masterfrom
yolanda15:add_relaxed_rminmax
Apr 17, 2026
Merged

Add WASM RELAXED-SIMD F32 RMINMAX microkernels#9940
copybara-service[bot] merged 1 commit intogoogle:masterfrom
yolanda15:add_relaxed_rminmax

Conversation

@yolanda15
Copy link
Copy Markdown
Contributor

@yolanda15 yolanda15 commented Apr 10, 2026

Add the missing WASM Relaxed simd f32 rminmax microkernels and update the reduce config to point to it.

copybara-service Bot pushed a commit that referenced this pull request Apr 13, 2026
--
b65fdc5 by Yolanda Chen <yolanda.chen@intel.com>:

Add WASM RELAXED-SIMD F32 RMINMAX microkernels

FUTURE_COPYBARA_INTEGRATE_REVIEW=#9940 from yolanda15:add_relaxed_rminmax b65fdc5
PiperOrigin-RevId: 898810254
copybara-service Bot pushed a commit that referenced this pull request Apr 13, 2026
--
b65fdc5 by Yolanda Chen <yolanda.chen@intel.com>:

Add WASM RELAXED-SIMD F32 RMINMAX microkernels

FUTURE_COPYBARA_INTEGRATE_REVIEW=#9940 from yolanda15:add_relaxed_rminmax b65fdc5
PiperOrigin-RevId: 898810254
#endif // XNN_ENABLE_AVX512F && (XNN_ARCH_X86 || XNN_ARCH_X86_64)

#if XNN_ARCH_WASMSIMD || XNN_ARCH_WASMRELAXEDSIMD
#if XNN_ARCH_WASMSIMD
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change breaks the wasmdimd build here because when XNN_ARCH_WASMRELAXEDSIMD is enabled, this kernel is not declared:

#elif XNN_ARCH_WASMSIMD || XNN_ARCH_WASMRELAXEDSIMD
f32_rminmax_config.ukernel = XNN_INIT_REDUCE_UKERNEL(xnn_f32_rminmax_ukernel__wasmsimd_minmax_u16_acc4);

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment! Do you think I should update reduce-config in this PR, or create a seperate PR to update it?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it depends on what you update it to. If you want the relaxed simd config to use these new kernels, I would just update it in this PR.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Thanks! I have uploaded the new change. Please note that it rebases with the latest change on wasm simd template from #9970.

@yolanda15 yolanda15 force-pushed the add_relaxed_rminmax branch from b65fdc5 to ff2d6b8 Compare April 15, 2026 07:00
copybara-service Bot pushed a commit that referenced this pull request Apr 17, 2026
--
ff2d6b8 by Yolanda Chen <yolanda.chen@intel.com>:

Add WASM RELAXED-SIMD F32 RMINMAX microkernels

FUTURE_COPYBARA_INTEGRATE_REVIEW=#9940 from yolanda15:add_relaxed_rminmax ff2d6b8
PiperOrigin-RevId: 898810254
copybara-service Bot pushed a commit that referenced this pull request Apr 17, 2026
--
ff2d6b8 by Yolanda Chen <yolanda.chen@intel.com>:

Add WASM RELAXED-SIMD F32 RMINMAX microkernels

FUTURE_COPYBARA_INTEGRATE_REVIEW=#9940 from yolanda15:add_relaxed_rminmax ff2d6b8
PiperOrigin-RevId: 898810254
@copybara-service copybara-service Bot merged commit fda2410 into google:master Apr 17, 2026
22 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants