Gandhiakshat/sbc amr sample app#597
Open
AkshatG6 wants to merge 4 commits intogandhiakshat/sbc-amr-mainfrom
Open
Gandhiakshat/sbc amr sample app#597AkshatG6 wants to merge 4 commits intogandhiakshat/sbc-amr-mainfrom
AkshatG6 wants to merge 4 commits intogandhiakshat/sbc-amr-mainfrom
Conversation
mdmathias
requested changes
Apr 7, 2026
Collaborator
mdmathias
left a comment
mdmathias
left a comment
There was a problem hiding this comment.
Can you add a video or screenshot?
|
|
||
| /// A view that displays a list of ID token claims. | ||
| struct ClaimsListView: View { | ||
| let claims: [(key: String, value: String)] |
Collaborator
There was a problem hiding this comment.
Why not just make a Claim type with key and value properties?
Collaborator
There was a problem hiding this comment.
Or, can you use GIDClaim?
Contributor
Author
There was a problem hiding this comment.
Creating a new Claim type because GIDClaim already exists and is used for requests instead of responses.
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the sample app to display all
claimsin a collective, navigable list rather than showing them individually in the user profile.