Ensure additionalTokenRefreshParametersForAuthSession returns a string dictionary#563
Closed
Ensure additionalTokenRefreshParametersForAuthSession returns a string dictionary#563
additionalTokenRefreshParametersForAuthSession returns a string dictionary#563Conversation
This pull request introduces the `GIDTokenClaimsInternalOptions` class, a new component designed to handle the validation and JSON serialization of token claims. Key changes: * Adds the `GIDTokenClaimsInternalOptions` class to validate the token claims and return a JSON object. * Adds the `GIDJSONSerializer` protocol with real and fake implementations to support serializing the token claims. * Provides unit tests to validate the implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a runtime crash that occurs when the dictionary returned by
additionalTokenRefreshParametersForAuthSession:contains non-string values, leading to a type mismatch in GTMAppAuth. (Fixes #505)This fix is implemented in
GIDEMMSupportby iterating through theadditionalParametersdictionary and converts values to strings with the following logic :-NSStringvalues: Preserves them as-is.NSNumbervalues: Converts booleans to their string representation ("true" or "false") and all other numbers to their standard string value.updatedEMMParametersWithParametersandparametersWithParametersis updated from(NSDictionary *)to(NSDictionary<NSString *, NSString *> *).This ensures that the dictionary returned to GTMAppAuth is always of the correct type.