Skip to content

Added battery not low and storage not low as download requirements #7138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jdegroot-dss wants to merge 5 commits into
base: dev-v2
Choose a base branch
from
Open

Added battery not low and storage not low as download requirements #7138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9fbd399
Added battery not low and storage not low as download requirements to…
jdegroot-dss Mar 24, 2020
36d11e5
Fixed linking to sources in battery and storage monitoring
jdegroot-dss Mar 31, 2020
6ddd904
Added getSupportedRequirements method to Scheduler interface
jdegroot-dss Apr 28, 2020
56fd460
Merge branch 'dev-v2' into add-download-requirements
jdegroot-dss Apr 28, 2020
4299342
Changed intent filter for battery not low to listen to the ACTION_BAT…
jdegroot-dss Apr 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions demos/main/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ dependencies {
implementation project(modulePrefix + 'library-hls')
implementation project(modulePrefix + 'library-smoothstreaming')
implementation project(modulePrefix + 'library-ui')
withExtensionsImplementation project(path: modulePrefix + 'extension-workmanager')
withExtensionsImplementation project(path: modulePrefix + 'extension-av1')
withExtensionsImplementation project(path: modulePrefix + 'extension-ffmpeg')
withExtensionsImplementation project(path: modulePrefix + 'extension-flac')
Expand Down
29 changes: 29 additions & 0 deletions ...src/main/java/com/google/android/exoplayer2/ext/jobdispatcher/JobDispatcherScheduler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,27 @@ public boolean cancel() {
return result == FirebaseJobDispatcher.CANCEL_RESULT_SUCCESS;
}

@Override
public Requirements getSupportedRequirements(Requirements requirements) {
Requirements supportedRequirements = requirements;
if (requirements.isBatteryNotLowRequired()) {
Log.w(TAG, "Battery not low requirement not supported on the JobDispatcherScheduler "
+ "Requirement removed.");
int newRequirements =
supportedRequirements.getRequirements() ^ Requirements.DEVICE_BATTERY_NOT_LOW;
supportedRequirements = new Requirements(newRequirements);
}

if (requirements.isStorageNotLowRequired()) {
Log.w(TAG, "Storage not low requirement not supported on the JobDispatcherScheduler "
+ "Requirement removed.");
int newRequirements =
supportedRequirements.getRequirements() ^ Requirements.DEVICE_STORAGE_NOT_LOW;
supportedRequirements = new Requirements(newRequirements);
}
return supportedRequirements;
}

private static Job buildJob(
FirebaseJobDispatcher dispatcher,
Requirements requirements,
Expand All @@ -120,6 +141,14 @@ private static Job buildJob(
if (requirements.isChargingRequired()) {
builder.addConstraint(Constraint.DEVICE_CHARGING);
}

if (requirements.isBatteryNotLowRequired()) {
Log.w(TAG, "Battery not low requirement is not supported on the JobDispatcherScheduler");
}
if (requirements.isStorageNotLowRequired()) {
Log.w(TAG, "Storage not low requirement is not supported on the JobDispatcherScheduler");
}

builder.setLifetime(Lifetime.FOREVER).setReplaceCurrent(true);

Bundle extras = new Bundle();
Expand Down
23 changes: 23 additions & 0 deletions ...ger/src/main/java/com/google/android/exoplayer2/ext/workmanager/WorkManagerScheduler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,16 @@ private static Constraints buildConstraints(Requirements requirements) {

if (requirements.isIdleRequired() && Util.SDK_INT >= 23) {
setRequiresDeviceIdle(builder);
} else if (requirements.isIdleRequired()) {
Log.w(TAG, "Is idle requirements is only available on API 23 and up.");
}

if (requirements.isBatteryNotLowRequired()) {
builder.setRequiresBatteryNotLow(true);
}

if (requirements.isStorageNotLowRequired()) {
builder.setRequiresStorageNotLow(true);
}

return builder.build();
Expand All @@ -108,6 +118,19 @@ private static Data buildInputData(
return builder.build();
}

@Override
public Requirements getSupportedRequirements(Requirements requirements) {
Requirements supportedRequirements = requirements;
if (requirements.isIdleRequired() && Util.SDK_INT < 23) {
Log.w(TAG, "Is idle requirement not supported on the WorkManagerScheduler on API below 23. "
+ "Requirement removed.");
int newRequirements =
supportedRequirements.getRequirements() ^ Requirements.DEVICE_IDLE;
supportedRequirements = new Requirements(newRequirements);
}
return supportedRequirements;
}

private static OneTimeWorkRequest buildWorkRequest(Constraints constraints, Data inputData) {
OneTimeWorkRequest.Builder builder = new OneTimeWorkRequest.Builder(SchedulerWorker.class);

Expand Down
5 changes: 5 additions & 0 deletions library/core/src/main/java/com/google/android/exoplayer2/offline/DownloadService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import android.os.Looper;
import androidx.annotation.Nullable;
import androidx.annotation.StringRes;
import com.google.android.exoplayer2.scheduler.PlatformScheduler;
import com.google.android.exoplayer2.scheduler.Requirements;
import com.google.android.exoplayer2.scheduler.Scheduler;
import com.google.android.exoplayer2.util.Assertions;
Expand Down Expand Up @@ -658,6 +659,10 @@ public int onStartCommand(@Nullable Intent intent, int flags, int startId) {
if (requirements == null) {
Log.e(TAG, "Ignored SET_REQUIREMENTS: Missing " + KEY_REQUIREMENTS + " extra");
} else {
@Nullable Scheduler scheduler = getScheduler();
if (scheduler != null) {
requirements = scheduler.getSupportedRequirements(requirements);
}
downloadManager.setRequirements(requirements);
}
break;
Expand Down
30 changes: 30 additions & 0 deletions library/core/src/main/java/com/google/android/exoplayer2/scheduler/PlatformScheduler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,29 @@ public boolean cancel() {
return true;
}

@Override
public Requirements getSupportedRequirements(Requirements requirements) {
Requirements supportedRequirements = requirements;
if (Util.SDK_INT < 26) {
if (requirements.isBatteryNotLowRequired()) {
Log.w(TAG, "Battery not low requirement not supported on the PlatformScheduler"
+ "on API below 26. Requirement removed.");
int newRequirements =
supportedRequirements.getRequirements() ^ Requirements.DEVICE_BATTERY_NOT_LOW;
supportedRequirements = new Requirements(newRequirements);
}

if (requirements.isStorageNotLowRequired()) {
Log.w(TAG, "Storage not low requirement not supported on the PlatformScheduler"
+ "on API below 26. Requirement removed.");
int newRequirements =
supportedRequirements.getRequirements() ^ Requirements.DEVICE_STORAGE_NOT_LOW;
supportedRequirements = new Requirements(newRequirements);
}
}
return supportedRequirements;
}

// @RequiresPermission constructor annotation should ensure the permission is present.
@SuppressWarnings("MissingPermission")
private static JobInfo buildJobInfo(
Expand All @@ -103,6 +126,13 @@ private static JobInfo buildJobInfo(
}
builder.setRequiresDeviceIdle(requirements.isIdleRequired());
builder.setRequiresCharging(requirements.isChargingRequired());
if (Util.SDK_INT >= 26) {
builder.setRequiresStorageNotLow(requirements.isStorageNotLowRequired());
builder.setRequiresBatteryNotLow(requirements.isBatteryNotLowRequired());
} else if (requirements.isStorageNotLowRequired() || requirements.isBatteryNotLowRequired()) {
Log.w(TAG, "Storage not low and battery not low requirements are only available on API 26"
+ " and up.");
}
builder.setPersisted(true);

PersistableBundle extras = new PersistableBundle();
Expand Down
74 changes: 73 additions & 1 deletion library/core/src/main/java/com/google/android/exoplayer2/scheduler/Requirements.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public final class Requirements implements Parcelable {
@Retention(RetentionPolicy.SOURCE)
@IntDef(
flag = true,
value = {NETWORK, NETWORK_UNMETERED, DEVICE_IDLE, DEVICE_CHARGING})
value = {NETWORK, NETWORK_UNMETERED, DEVICE_IDLE, DEVICE_CHARGING, DEVICE_BATTERY_NOT_LOW, DEVICE_STORAGE_NOT_LOW})
public @interface RequirementFlags {}

/** Requirement that the device has network connectivity. */
Expand All @@ -56,6 +56,16 @@ public final class Requirements implements Parcelable {
public static final int DEVICE_IDLE = 1 << 2;
/** Requirement that the device is charging. */
public static final int DEVICE_CHARGING = 1 << 3;
/** Requirement that the storage is not low. */
public static final int DEVICE_STORAGE_NOT_LOW = 1 << 4;
/** Requirement that the battery is not low. */
public static final int DEVICE_BATTERY_NOT_LOW = 1 << 5;

/** Constant indicating the battery is not plugged in a power source */
private static final int BATTERY_PLUGGED_NONE = 0;
/** Constant when the battery is considered low (in percentage) */
private static final float BATTERY_LOW_PERCENTAGE = 0.15f;


@RequirementFlags private final int requirements;

Expand Down Expand Up @@ -94,6 +104,14 @@ public boolean isIdleRequired() {
return (requirements & DEVICE_IDLE) != 0;
}

public boolean isStorageNotLowRequired() {
return (requirements & DEVICE_STORAGE_NOT_LOW) != 0;
}

public boolean isBatteryNotLowRequired() {
return (requirements & DEVICE_BATTERY_NOT_LOW) != 0;
}

/**
* Returns whether the requirements are met.
*
Expand All @@ -119,6 +137,12 @@ public int getNotMetRequirements(Context context) {
if (isIdleRequired() && !isDeviceIdle(context)) {
notMetRequirements |= DEVICE_IDLE;
}
if (isBatteryNotLowRequired() && !isBatteryNotLow(context)) {
notMetRequirements |= DEVICE_BATTERY_NOT_LOW;
}
if (isStorageNotLowRequired() && !isStorageNotLow(context)) {
notMetRequirements |= DEVICE_STORAGE_NOT_LOW;
}
return notMetRequirements;
}

Expand Down Expand Up @@ -162,6 +186,54 @@ private boolean isDeviceIdle(Context context) {
: Util.SDK_INT >= 20 ? !powerManager.isInteractive() : !powerManager.isScreenOn();
}

/**
* Implementation taken from the the WorkManager source.
* @see <a href="https://android.googlesource.com/platform/frameworks/support/+/androidx-master-dev/work/workmanager/src/main/java/androidx/work/impl/constraints/trackers/BatteryNotLowTracker.java">BatteryNotLowTracker</a>
*/
private boolean isBatteryNotLow(Context context) {
Copy link
Contributor

@ojw28 ojw28 Mar 31, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extent this is decoupled from RequirementsWatcher makes me pretty uncomfortable. If ACTION_BATTERY_LOW and ACTION_BATTERY_OK aren't fired at exactly the right time either side of the 15% magic battery percentage value, then the RequirementsWatcher isn't going to re-evaluate the Requirements correctly, and there wont necessarily be another intent fired to cause re-evaluation after that. The file you reference is interesting in that it effectively lets the ACTION_BATTERY_LOW and ACTION_BATTERY_OK intents override what the ACTION_BATTERY_CHANGED intent says, which is only used for an initial evaluation.

How thoroughly did you test this, and are you certain it's always going to work? Is it possible to use ACTION_BATTERY_LOW and ACTION_BATTERY_OK for the evaluation, rather than ACTION_BATTERY_CHANGED? I'm guessing not because they don't appear to be sticky, but please double check.

As a more general point, I think we should probably move evaluation of the requirements out of Requirements and into RequirementsWatcher, to let us do things like modify the evaluated state when we receive ACTION_BATTERY_LOW and ACTION_BATTERY_OK, rather than just having them trigger a re-evaluation.

Depending on how confident you are about the battery part of this change, I see two paths forward here:

  1. Scope this change down to just cover the storage part. Then refactor as suggested above as a second change. Then add the battery part as a third change.
  2. Submit this with both storage and battery parts, and refactor as suggested afterwards.

Copy link
Contributor

@ojw28 ojw28 Mar 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it happens infrequently, it may be acceptable to use ACTION_BATTERY_CHANGED in RequirementsWatcher to get them aligned. This presumably also solves the problem below about the plugged state, since I'm guessing that is fired when the plugged state changes?

Copy link
Contributor Author

@jdegroot-dss jdegroot-dss Apr 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will retest the battery part more thoroughly, I've been testing on emulators and the Intents fired consistently between ACTION_BATTERY_LOW and ACTION_BATTERY_OK. What I did not test is a device where the battery low percentage is not 15% (my personal device starts warning at 20% for example). Good idea to look into the frequency of ACTION_BATTERY_CHANGED as well, will get back to you on the battery part.

I'd prefer to submit the storage and battery changes, including refactor, as one change if that's OK with you.

Copy link
Contributor

@ojw28 ojw28 Apr 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change sounds fine provided you can get the battery part to a state where it looks robust, without the need to additional refactoring. If additional refactoring is needed then we should start splitting it into smaller changes, which are easier to review and merge.

Copy link
Contributor Author

@jdegroot-dss jdegroot-dss Apr 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some more thorough testing on the battery part and have the following findings:

Is it possible to use ACTION_BATTERY_LOW and ACTION_BATTERY_OK for the evaluation, rather than ACTION_BATTERY_CHANGED?

This is indeed not possible as ACTION_BATTERY_LOW and ACTION_BATTERY_OK don't contain the intent extras needed for the evaluation.

If it happens infrequently, it may be acceptable to use ACTION_BATTERY_CHANGED in RequirementsWatcher to get them aligned

ACTION_BATTERY_CHANGED fires on every "tick" of the battery level, as well as on connect and disconnect from a power source as you expected. The intent does fire more often but it is a more robust solution as ACTION_BATTERY_LOW and ACTION_BATTERY_OK seem to be device specific with respect to when they fire. For example on another test device the battery is only considered low when there's 10% left. Additionally I've seen some instances where ACTION_BATTERY_OK doesn't fire immediately after the battery level goes above the low threshold. If we use ACTION_BATTERY_CHANGED the behaviour will be consistent across devices using the same magic value we choose as the low threshold.

IntentFilter intentFilter = new IntentFilter(Intent.ACTION_BATTERY_CHANGED);
Intent intent = context.registerReceiver(null, intentFilter);
if (intent == null) {
return true;
}
int plugged = intent.getIntExtra(BatteryManager.EXTRA_PLUGGED, BATTERY_PLUGGED_NONE);
int status = intent.getIntExtra(BatteryManager.EXTRA_STATUS, -1);
int level = intent.getIntExtra(BatteryManager.EXTRA_LEVEL, -1);
int scale = intent.getIntExtra(BatteryManager.EXTRA_SCALE, -1);
float batteryPercentage = level / (float) scale;
return (plugged != BATTERY_PLUGGED_NONE
Copy link
Contributor

@ojw28 ojw28 Mar 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is part of the logic, you'll want RequirementsWatcher to trigger a re-evaluation when the battery is plugged or unplugged. I can't see anything that does this, however, unless ACTION_BATTERY_OKAY and ACTION_BATTERY_LOW are fired when the battery is plugged or unplugged when under 15% (if this does happen, it doesn't appear to be documented in the Android Javadoc).

Do you need to change if (requirements.isChargingRequired()) { on L95 of RequirementsWatcher to also evaluate to true if isBatteryNotLowRequired?

If this is a bug, it's probably also a bug in the referenced BatteryNotLowTracker class?

Copy link
Contributor Author

@jdegroot-dss jdegroot-dss Apr 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right that this indeed seems to be a bug in the BatteryNotLowTracker as there is no re-evaluation after a device is connected to power. Changing the intent filter to use ACTION_BATTERY_CHANGED fixed this issue.

Copy link
Contributor

@ojw28 ojw28 May 18, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spoke to the maintainers of BatteryNotLowTracker and they don't think looking at plugged should have been part of the evaluation at all, and so have removed it.

There remains an additional issue that by using ACTION_BATTERY_CHANGED for the initial evaluation, but using ACTION_BATTERY_OKAY and ACTION_BATTERY_LOW for detecting state changes, it's possible that BatteryNotLowTracker can end up out of sync with the true battery state if the underlying platform uses some constant other than 15% to fire the latter two intents. Furthermore, they cannot use ACTION_BATTERY_CHANGED because it can't be used with a broadcast receiver, and they cannot use the other intents for the initial evaluation because they're not sticky. It seems like a platform change would be needed to solve this problem robustly.

Given this, do we want to add support for battery-not-low at all? It's not supported by two of the ExoPlayer Scheduler implementations, and we think that the third one does not support it in a robust way, and that it's unlikely to be possible for that to be fixed short of a new Android platform release. So it feels we're adding a feature that we know is not robust under any circumstance...

Copy link
Contributor Author

@jdegroot-dss jdegroot-dss May 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Furthermore, they cannot use ACTION_BATTERY_CHANGED because it can't be used with a broadcast receiver

Could you elaborate on this point a bit more? Based on the documentation for ACTION_BATTERY_CHANGED it seems it can only not be used to register in the manifest, but can be explicitly registered for (as also done in the revised RequirementsWatcher. But maybe I'm missing something here.

Additionally, are there plans to remove support for battery not low for the WorkManager as well?

Given this, do we want to add support for battery-not-low at all?

As you say there's no robust solution for battery not low, so it seems reasonable to remove support for it until the necessary platform changes are made. Shall I close this PR and reopen a new one with just the storage not low requirement?

Copy link
Contributor

@ojw28 ojw28 May 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you elaborate on this point a bit more? Based on the documentation for ACTION_BATTERY_CHANGED it seems it can only not be used to register in the manifest, but can be explicitly registered for (as also done in the revised RequirementsWatcher. But maybe I'm missing something here.

Right, sorry, that wasn't clear. What I meant is that they can't listen register a receiver in the manifest, which is what they need to do.

Additionally, are there plans to remove support for battery not low for the WorkManager as well?

There's an active discussion happening now about what to do about work manager. From the latest update it seems the 15% magic value for firing ACTION_BATTERY_LOW and ACTION_BATTERY_OK may be enforced by a device certification (CTS) test. If that's the case, their solution will probably be robust after all, once the plugged check has been removed. It still seems worth trying to validate this across some different devices, to make sure. I know you mentioned you have a test device where battery is only considered low when there's 10% left. Were you seeing ACTION_BATTERY_LOW and ACTION_BATTERY_OK fired at 10%, or were they still fired at 15% (as we'd expect if there's a device certification test) and was this just the phone UI using a different value?

If we're able to validate the 15% magic value across different devices, including the one where you saw 10% being used for something, then it seems OK that we would add support in ExoPlayer. We will at least need to wait until a new release of workmanager to pick up the change that removes the plugged check though, and also remove it from the ExoPlayer code to keep the two in sync.

Apologies for the gradual sharing of new information; the discussions internally have been ongoing, so I'm just sharing things as I find out about them.

In terms of next steps:

  1. The storage-not-low part is non-controversial. If there was a pull request for just that part, we could easily merge it.
  2. For battery, it seems we need to validate the 15% value for when the non-sticky intents are fired, particularly on the device where you saw 10% being used for something. Our main concern here is to avoid adding a feature if it's not robust. If you can successfully validate the 15% value for the non-sticky intents, then we can merge the battery part too once WorkManager is updated to remove their plugged check. In this case, keeping both in the same pull request is reasonable if you want to avoid splitting it, with the caveat that we can't merge it until the new WorkManager release exists. In the case that validation isn't successful, I don't think we should add support because that would imply WorkManager's BatteryNotLowTracker is not robust.

Copy link
Contributor Author

@jdegroot-dss jdegroot-dss May 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you seeing ACTION_BATTERY_LOW and ACTION_BATTERY_OK fired at 10%, or were they still fired at 15% (as we'd expect if there's a device certification test) and was this just the phone UI using a different value?

On that test device ACTION_BATTERY_LOW is fired at 10% battery remaining and ACTION_BATTERY_OK when the battery is back to 15%. The latter is only fired when the battery went down to 10% first, i.e. when it goes down to 14% and then back to 15% ACTION_BATTERY_OK is not fired. Maybe this is not a certified device (it's a Huawei Mate 20)?

In any case it seems that not every device abides the 15% rule, so in terms of next steps I'll put up a new PR with just the storage not low requirement. If something changes with the battery monitoring implementation we could try adding the battery requirement as well?

Apologies for the gradual sharing of new information; the discussions internally have been ongoing, so I'm just sharing things as I find out about them.

No worries, I appreciate you sharing the info!

Copy link
Contributor

@ojw28 ojw28 May 19, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In any case it seems that not every device abides the 15% rule, so in terms of next steps I'll put up a new PR with just the storage not low requirement. If something changes with the battery monitoring implementation we could try adding the battery requirement as well?

Sounds good to me! Maybe just keep this one open as well so that we have the battery stuff to hand for if/when we want to use it.

On that test device ACTION_BATTERY_LOW is fired at 10% battery remaining and ACTION_BATTERY_OK when the battery is back to 15%. The latter is only fired when the battery went down to 10% first, i.e. when it goes down to 14% and then back to 15% ACTION_BATTERY_OK is not fired. Maybe this is not a certified device (it's a Huawei Mate 20)?

Interesting. I will follow up.

Copy link
Contributor

@ojw28 ojw28 May 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On that test device ACTION_BATTERY_LOW is fired at 10% battery remaining and ACTION_BATTERY_OK when the battery is back to 15%. The latter is only fired when the battery went down to 10% first, i.e. when it goes down to 14% and then back to 15% ACTION_BATTERY_OK is not fired. Maybe this is not a certified device (it's a Huawei Mate 20)?

If the battery goes from 9% to 11% to 9%, is ACTION_BATTERY_LOW fired again in that case? Or does it behave similarly to ACTION_BATTERY_OK and only fire if the battery goes up above 15% in-between?

Copy link
Contributor Author

@jdegroot-dss jdegroot-dss May 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case ACTION_BATTERY_LOW is fired again when the battery goes down from 11% to 9%.

Forgot to mention that neither ACTION_BATTERY_LOW nor ACTION_BATTERY_OK fire when the device is connected to a power source (which might be expected).

|| status == BatteryManager.BATTERY_STATUS_UNKNOWN
|| batteryPercentage > BATTERY_LOW_PERCENTAGE);
}

/**
* Implementation taken from the the WorkManager source.
* @see <a href="https://android.googlesource.com/platform/frameworks/support/+/androidx-master-dev/work/workmanager/src/main/java/androidx/work/impl/constraints/trackers/StorageNotLowTracker.java">StorageNotLowTracker</a>
*/
private boolean isStorageNotLow(Context context) {
IntentFilter intentFilter = new IntentFilter();
intentFilter.addAction(Intent.ACTION_DEVICE_STORAGE_OK);
intentFilter.addAction(Intent.ACTION_DEVICE_STORAGE_LOW);
Intent intent = context.registerReceiver(null, intentFilter);
if (intent == null || intent.getAction() == null) {
// ACTION_DEVICE_STORAGE_LOW is a sticky broadcast that is removed when sufficient
// storage is available again. ACTION_DEVICE_STORAGE_OK is not sticky. So if we
// don't receive anything here, we can assume that the storage state is okay.
return true;
} else {
switch (intent.getAction()) {
case Intent.ACTION_DEVICE_STORAGE_OK:
return true;
case Intent.ACTION_DEVICE_STORAGE_LOW:
return false;
default:
// This should never happen because the intent filter is configured
// correctly.
return true;
}
}
}

private static boolean isInternetConnectivityValidated(ConnectivityManager connectivityManager) {
// It's possible to query NetworkCapabilities from API level 23, but RequirementsWatcher only
// fires an event to update its Requirements when NetworkCapabilities change from API level 24.
Expand Down
7 changes: 7 additions & 0 deletions library/core/src/main/java/com/google/android/exoplayer2/scheduler/RequirementsWatcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,13 @@ public int start() {
filter.addAction(Intent.ACTION_SCREEN_OFF);
}
}
if (requirements.isStorageNotLowRequired()) {
filter.addAction(Intent.ACTION_DEVICE_STORAGE_LOW);
filter.addAction(Intent.ACTION_DEVICE_STORAGE_OK);
}
if (requirements.isBatteryNotLowRequired()) {
filter.addAction(Intent.ACTION_BATTERY_CHANGED);
}
receiver = new DeviceStatusChangeReceiver();
context.registerReceiver(receiver, filter, null, handler);
return notMetRequirements;
Expand Down
9 changes: 9 additions & 0 deletions library/core/src/main/java/com/google/android/exoplayer2/scheduler/Scheduler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,13 @@ public interface Scheduler {
* @return Whether cancellation was successful.
*/
boolean cancel();

/**
* Checks if this {@link Scheduler} supports the provided {@link Requirements}. If all
* requirements are supported the same object is returned. If not all requirements are
* supported a new {@code Requirements} object is returned containing the supported requirements.
* @param requirements The requirements to check.
* @return The requirements supported by this scheduler.
*/
Requirements getSupportedRequirements(Requirements requirements);
}