[web] Update shell styles #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullewis
force-pushed
the
update-shell-styles
branch
from
dfa925f to
70311f1
Compare
ava-cassiopeia
approved these changes
Dec 11, 2025
Collaborator
ava-cassiopeia
left a comment
ava-cassiopeia
left a comment
There was a problem hiding this comment.
LGTM, just a few small comments; feel free to follow up on them in a different PR.
renderers/lit/src/0.8/ui/text.ts
Outdated
Comment on lines
+121
to
+130
| let additionalStyles: Record<string, string> = {}; | ||
| const styles = this.theme.additionalStyles?.Text; | ||
| if (styles) { | ||
| if ("h1" in styles) { | ||
| const hint = this.usageHint ?? "body"; | ||
| additionalStyles = styles[hint] as Record<string, string>; | ||
| } else { | ||
| additionalStyles = styles; | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
NIT: this logic smells to me like it would be better served as its own private method for readability, as you could improve the readability by using guard clauses instead of nested conditionals; something like:
#getAdditionalStyles(...): Record<string, string> {
const styles = this.theme.additionalStyles?.Text;
if (!styles) return {};
// etc.
}Feel free to do this in a followup PR if you want.
renderers/lit/src/0.8/ui/surface.ts
Outdated
| 100 - i | ||
| }%, #fff ${i}%)`; | ||
| } | ||
| // Ignored for now. |
Collaborator
There was a problem hiding this comment.
NIT: Is it worth clarifying why this is being ignored? Here and below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the styling in line with the pre-existing theme machinery. This applies to both the restaurant and contacts examples for both light & dark themes.