Skip to content

Remove TensorFlow dependency and migrate cifar10_resnet to Flax NNX#1508

Merged
copybara-service[bot] merged 3 commits intogoogle-deepmind:mainfrom
selamw1:cifir10-resnet-fix
Apr 22, 2026
Merged

Remove TensorFlow dependency and migrate cifar10_resnet to Flax NNX#1508
copybara-service[bot] merged 3 commits intogoogle-deepmind:mainfrom
selamw1:cifir10-resnet-fix

Conversation

@selamw1
Copy link
Copy Markdown
Collaborator

@selamw1 selamw1 commented Nov 20, 2025

This PR addresses issue #656 by removing the TensorFlow dependency from the cifar10_resnet notebook. Additionally, it updates the notebook to use Flax NNX instead of flax.linen, aligning the example with modern JAX best practices.

@rdyro
Copy link
Copy Markdown
Collaborator

rdyro commented Dec 3, 2025

The notebook doesn't render for me, can you check it's formatted correctly?

rendering issue resolved

clear all output
@selamw1 selamw1 force-pushed the cifir10-resnet-fix branch from cdba0d2 to 6d4c831 Compare December 3, 2025 23:17
@selamw1
Copy link
Copy Markdown
Collaborator Author

selamw1 commented Dec 3, 2025

The notebook doesn't render for me, can you check it's formatted correctly?

Incompatibility issue with Jupyter Widgets rendering resolved.

@vroulet
Copy link
Copy Markdown
Collaborator

vroulet commented Jan 22, 2026

Thanks @selamw1, looks good to me overall.
Could you sync, merge conflicts, check that it renders well and ping me when it's done so that I merge it ?
Thanks again!

@selamw1
Copy link
Copy Markdown
Collaborator Author

selamw1 commented Jan 22, 2026

Thanks @vroulet, branch conflict resolved and now it renders well.

Copy link
Copy Markdown
Collaborator

@rdyro rdyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@copybara-service copybara-service Bot merged commit 71dc2e7 into google-deepmind:main Apr 22, 2026
16 checks passed
@selamw1 selamw1 deleted the cifir10-resnet-fix branch April 22, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants