Pass delete_on_close=False to NamedTemporaryFile().#266
Merged
copybara-service[bot] merged 1 commit intomainfrom Mar 3, 2025
Merged
Pass delete_on_close=False to NamedTemporaryFile().#266copybara-service[bot] merged 1 commit intomainfrom
delete_on_close=False to NamedTemporaryFile().#266copybara-service[bot] merged 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_732946651
branch
3 times, most recently
from
9efb6cd to
58dd015
Compare
The behavior of [`NamedTemporaryFile()`](https://docs.python.org/3/library/tempfile.html#tempfile.NamedTemporaryFile) is slightly different on Windows when the file is accessed multiple times in the same context manager. `delete_on_close=False` allows the file to exist until the end of the context manager, which is the behavior we want in all platforms. Unfortunately this argument was only added in Python `3.12`, so we add a switch to support earlier versions. We may remove it in the future once `3.11` is EOL. Please see PR #265 for details (and thanks to @NingLi670 for opening the original PR). PiperOrigin-RevId: 732961399
copybara-service
bot
force-pushed
the
test_732946651
branch
from
58dd015 to
c16c209
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass
delete_on_close=FalsetoNamedTemporaryFile().The behavior of
NamedTemporaryFile()is slightly different on Windows when the file is accessed multiple times in
the same context manager.
delete_on_close=Falseallows the file to existuntil the end of the context manager, which is the behavior we want in all
platforms.
Unfortunately this argument was only added in Python
3.12, so we add a switchto support earlier versions. We may remove it in the future once
3.11is EOL.Please see PR #265 for
details (and thanks to @NingLi670 for opening the original PR).