fix: add missing run.sh for x402 human-present scenario#170
fix: add missing run.sh for x402 human-present scenario#170Ayush10 wants to merge 2 commits intogoogle-agentic-commerce:mainfrom
Conversation
Add a convenience run.sh script to the x402 scenario directory that delegates to the existing cards/run.sh with --payment-method x402. Update the x402 README to reference its own run.sh. Closes google-agentic-commerce#107
Summary of ChangesHello @Ayush10, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the developer experience for the x402 human-present scenario by introducing a dedicated convenience script. This change streamlines the process of initiating the scenario, making it easier for users to get started without needing to remember specific command-line arguments for the underlying generic run script. The accompanying documentation update ensures that users are guided to use this new, simplified method. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a helpful convenience script run.sh for the x402 scenario, simplifying the execution command for users. The accompanying README update is also correct. I've suggested a small improvement to the new script to make it more flexible for future changes.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Summary
run.shscript tosamples/python/scenarios/a2a/human-present/x402/that delegates to the existingcards/run.shwith--payment-method x402run.shinstead of pointing tocards/run.shCloses #107
Test plan
bash samples/python/scenarios/a2a/human-present/x402/run.shstarts the x402 scenario correctlycards/run.shwith the correct--payment-method x402flag