[bot] Merge master/7d482a0f into rel/dev#1396
Merged
yenkins-admin merged 2 commits intorel/devfrom Mar 6, 2026
Merged
Conversation
`create_directory` uses a check-then-create pattern (`os.path.exists` + `os.makedirs`) which is not atomic. When multiple threads call `load_from_disk` on the same path concurrently (e.g. parallel workspace uploads), they race on creating directories like `analytical_dashboard_extensions`, causing `FileExistsError`. Replace with `os.makedirs(path, exist_ok=True)` which handles this atomically. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ition fix: use exist_ok=True in create_directory to prevent race condition
yenkins-admin
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1396 +/- ##
===========================================
- Coverage 77.53% 77.53% -0.01%
===========================================
Files 225 225
Lines 14615 14614 -1
===========================================
- Hits 11332 11331 -1
Misses 3283 3283 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Automated PR to perform merge from master into rel/dev with changes up to 7d482a0 (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/22757919120).