Add warning for using array pattern with packed arrays#11907
Open
stdc105 wants to merge 1 commit intogodotengine:masterfrom
Open
Add warning for using array pattern with packed arrays#11907stdc105 wants to merge 1 commit intogodotengine:masterfrom
stdc105 wants to merge 1 commit intogodotengine:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've recently encountered a "papercut" when using pattern matching after
String.split: the split result is aPackedStringArraythat does not work with array patterns. While there is a warning in the pattern matching about the type strictness above, it might also help to add an additional warning in the "Array pattern" section as it's pretty far down in the docs, a couple screens of scroll from the warning above.I wonder if it's also worth a proposal to add matching packed arrays with array pattern too, as they are quite similar to arrays in many ways, and definitely more comparable to
StringNamevs.Stringthanfloatvs.int.