Skip to content

Align MethodInfo equality check with engine#1965

Open
Naros wants to merge 1 commit intogodotengine:masterfrom
Naros:fix-methodinfo-equality-check
Open

Align MethodInfo equality check with engine#1965
Naros wants to merge 1 commit intogodotengine:masterfrom
Naros:fix-methodinfo-equality-check

Conversation

@Naros
Copy link
Copy Markdown
Contributor

@Naros Naros commented Apr 5, 2026

Fixes the MethodInfo equality operator== check to use the name like in the engine.

I came across this because I was using some similar code to the engine that does:

if (!(info == MethodInfo())) {
  /* do stuff */
}

And I could not understand why a full MethodInfo would not trigger the if-block. 😭

@Naros Naros requested a review from a team as a code owner April 5, 2026 22:15
@Naros
Copy link
Copy Markdown
Contributor Author

Naros commented Apr 5, 2026

@dsnopek @Ivorforce, this is at least the second or third time I've come across inconsistencies between these structs (MethodInfo / PropertyInfo), since they're defined in both the engine and the godot-cpp side. Is there any chance we can develop some sort of check that prevents this from happening, where the engine and godot-cpp get out of sync?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant