Align MethodInfo equality check with engine#1965
Open
Naros wants to merge 1 commit intogodotengine:masterfrom
Open
Align MethodInfo equality check with engine#1965Naros wants to merge 1 commit intogodotengine:masterfrom
Naros wants to merge 1 commit intogodotengine:masterfrom
Conversation
Contributor
Author
|
@dsnopek @Ivorforce, this is at least the second or third time I've come across inconsistencies between these structs (MethodInfo / PropertyInfo), since they're defined in both the engine and the godot-cpp side. Is there any chance we can develop some sort of check that prevents this from happening, where the engine and godot-cpp get out of sync? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
MethodInfoequalityoperator==check to use thenamelike in the engine.I came across this because I was using some similar code to the engine that does:
And I could not understand why a full MethodInfo would not trigger the if-block. 😭