Do not clear variant on assignment to self#1960
Merged
dsnopek merged 1 commit intogodotengine:masterfrom Mar 30, 2026
Merged
Conversation
Ivorforce
approved these changes
Mar 30, 2026
dsnopek
approved these changes
Mar 30, 2026
Collaborator
dsnopek
left a comment
dsnopek
left a comment
There was a problem hiding this comment.
Thanks! Looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1959
As outlined in the issue, when working with an array of Variants, and you assign from one pointer to another, where both refer to the same memory location, the
godot-cppimplementation ofVariant::operator=clears the memory location, which yields the value after the assignment to be<null>due to the explicit call toclear().The engine, on the other hand, guards against this corner case and skips the assignment.