Style: Convert *.gen.inc to *.hpp for ninja#1927
Open
Repiteo wants to merge 1 commit intogodotengine:masterfrom
Open
Style: Convert *.gen.inc to *.hpp for ninja#1927Repiteo wants to merge 1 commit intogodotengine:masterfrom
*.gen.inc to *.hpp for ninja#1927Repiteo wants to merge 1 commit intogodotengine:masterfrom
Conversation
Repiteo
added
bug
Ivorforce
approved these changes
Feb 12, 2026
Member
Ivorforce
left a comment
Ivorforce
left a comment
There was a problem hiding this comment.
Works for me.
For godot-cpp we're trying to have a bit of a higher source code compat baseline than in the main repo, but I'm not sure how common it is to include gdvirtual manually.
The best workaround I can think of is still generating the .gen.inc, but making it an empty file except for a gdvirtual.hpp include. Not sure that's necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*.gen.incto*.gen.hfor ninja godot#115935While less pertinent on godot-cpp, the same issue could theoretically occur, so this moves away from the
.incsyntax for generated headers. However, the context of generating files in godot-cpp is much different than godot, so the extension is.hppinstead of.gen.h, as the.genparadigm isn't needed when we have a dedicated folder for generated files