Skip to content

Fix passing multiple XML doc sources to generate_doc_source#1918

Open
foxandfeature wants to merge 2 commits intogodotengine:masterfrom
foxandfeature:multiple-XML-doc-sources
Open

Fix passing multiple XML doc sources to generate_doc_source#1918
foxandfeature wants to merge 2 commits intogodotengine:masterfrom
foxandfeature:multiple-XML-doc-sources

Conversation

@foxandfeature
Copy link

CMake functions only received the first XML file due to argument expansion.
Quoting the SOURCES argument ensures multiple XML doc sources are passed correctly.

@foxandfeature foxandfeature requested a review from a team as a code owner January 31, 2026 18:08
@Ivorforce Ivorforce requested a review from enetheru January 31, 2026 18:09
@Ivorforce Ivorforce added bug This has been identified as a bug cmake labels Jan 31, 2026
Copy link
Collaborator

@enetheru enetheru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies for taking so long to review this simple change, you are quite right.
There is another location that also needs changing and that's in the test cmake file where is uses this function also:
test/CMakeLists.txt

# conditionally add doc data to compile output
if(GODOTCPP_TARGET MATCHES "editor|template_debug")
    file(GLOB_RECURSE DOC_XML LIST_DIRECTORIES NO CONFIGURE_DEPENDS "${CMAKE_CURRENT_SOURCE_DIR}/doc_classes/*.xml")
    target_doc_sources( ${TARGET_NAME} ${DOC_XML} ) # FIXME is missing quotes too.
endif()

I would really appreciate amending this PR to include this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This has been identified as a bug cmake

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants