Fix passing multiple XML doc sources to generate_doc_source#1918
Open
foxandfeature wants to merge 2 commits intogodotengine:masterfrom
Open
Fix passing multiple XML doc sources to generate_doc_source#1918foxandfeature wants to merge 2 commits intogodotengine:masterfrom
foxandfeature wants to merge 2 commits intogodotengine:masterfrom
Conversation
enetheru
approved these changes
Feb 6, 2026
Collaborator
enetheru
left a comment
There was a problem hiding this comment.
My apologies for taking so long to review this simple change, you are quite right.
There is another location that also needs changing and that's in the test cmake file where is uses this function also:
test/CMakeLists.txt
# conditionally add doc data to compile output
if(GODOTCPP_TARGET MATCHES "editor|template_debug")
file(GLOB_RECURSE DOC_XML LIST_DIRECTORIES NO CONFIGURE_DEPENDS "${CMAKE_CURRENT_SOURCE_DIR}/doc_classes/*.xml")
target_doc_sources( ${TARGET_NAME} ${DOC_XML} ) # FIXME is missing quotes too.
endif()I would really appreciate amending this PR to include this fix.
enetheru
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake functions only received the first XML file due to argument expansion.
Quoting the SOURCES argument ensures multiple XML doc sources are passed correctly.