-
Notifications
You must be signed in to change notification settings - Fork 48
VNEXT-68989 #1290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cvillacorta-godaddy
wants to merge
6
commits into
godaddy:main
Choose a base branch
from
cvillacorta-godaddy:vnext-68989
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
VNEXT-68989 #1290
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6919ef5
initial changes to add mercadopago
cvillacorta-godaddy 1507a66
mercadopago event tracking, improvement in rendering, placing dummy e…
cvillacorta-godaddy 87215f5
including changeset
cvillacorta-godaddy ef0b25e
run lint:fix
cvillacorta-godaddy a52fd9f
reverting gdp in example project
cvillacorta-godaddy b13cdcb
mercadopago form ouside the accordion, cleaning MercadoPagoProvider
cvillacorta-godaddy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| "nextjs": minor | ||
| "@godaddy/react": minor | ||
| --- | ||
|
|
||
| Implementation of mercadopago |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,20 @@ | ||
| { | ||
| "$schema": "https://biomejs.dev/schemas/2.3.3/schema.json", | ||
| "extends": ["biome-config-godaddy/biome.json"], | ||
| "css": { | ||
| "parser": { | ||
| "cssModules": true, | ||
| "tailwindDirectives": true | ||
| } | ||
| }, | ||
| "files": { | ||
| "includes": ["**/*", "!!**/src/globals.css"] | ||
| }, | ||
| "linter": { | ||
| "rules": { | ||
| "correctness": { | ||
| "useUniqueElementIds": "off" | ||
| } | ||
| } | ||
| } | ||
| "$schema": "https://biomejs.dev/schemas/2.3.3/schema.json", | ||
| "extends": ["biome-config-godaddy/biome.json"], | ||
| "css": { | ||
| "parser": { | ||
| "cssModules": true, | ||
| "tailwindDirectives": true | ||
| } | ||
| }, | ||
| "files": { | ||
| "includes": ["**/*", "!!**/src/globals.css"] | ||
| }, | ||
| "linter": { | ||
| "rules": { | ||
| "correctness": { | ||
| "useUniqueElementIds": "off" | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 changes: 42 additions & 0 deletions
42
packages/react/src/components/checkout/payment/checkout-buttons/credit-card/mercadopago.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| import { useFormContext } from 'react-hook-form'; | ||
| import { useMercadoPago } from '@/components/checkout/payment/utils/mercadopago-provider'; | ||
| import { Button } from '@/components/ui/button'; | ||
| import { useGoDaddyContext } from '@/godaddy-provider'; | ||
|
|
||
| export function MercadoPagoCreditCardCheckoutButton() { | ||
| const { t } = useGoDaddyContext(); | ||
| const { handleBrickSubmit, isLoading } = useMercadoPago(); | ||
| const form = useFormContext(); | ||
|
|
||
| const handleSubmit = async () => { | ||
| // Validate form first | ||
| const valid = await form.trigger(); | ||
| if (!valid) { | ||
| const firstError = Object.keys(form.formState.errors)[0]; | ||
| if (firstError) { | ||
| form.setFocus(firstError); | ||
| } | ||
| return; | ||
| } | ||
|
|
||
| // Trigger MercadoPago brick submission | ||
| if (handleBrickSubmit) { | ||
| try { | ||
| await handleBrickSubmit(); | ||
| } catch (error) { | ||
| console.error('MercadoPago submission error:', error); | ||
| } | ||
| } | ||
| }; | ||
|
|
||
| return ( | ||
| <Button | ||
| type='button' | ||
| onClick={handleSubmit} | ||
| disabled={!handleBrickSubmit || isLoading} | ||
| className='w-full' | ||
| > | ||
| {t.payment.payNow} | ||
| </Button> | ||
| ); | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the form should be a part of this instead of
payment-methods; but if decided that's not the way, this file is not needed.