refactor: update currency formatting to respect currency precision#1211
Closed
pbennett1-godaddy wants to merge 3 commits intomainfrom
Closed
refactor: update currency formatting to respect currency precision#1211pbennett1-godaddy wants to merge 3 commits intomainfrom
pbennett1-godaddy wants to merge 3 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: b320afd The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update Currency Formatting to Respect Currency Precision
Summary
Replaces hardcoded currency conversions (/ 100, * 100) and Intl.NumberFormat usages with a centralized formatCurrency utility function that respects each currency's precision configuration. This
enables proper support for currencies with different decimal places (e.g., USD with 2 decimals, VND with 0 decimals, etc.).
Key Improvements
- Created new formatCurrency utility function with support for 31+ currencies
- Each currency has its own precision configuration (USD: 2, VND: 0, CLP: 0, etc.)
- Eliminates hardcoded assumptions about decimal places
- Removed all / 100 and * 100 hardcoded conversions throughout the codebase
- Currency conversions now respect currency-specific precision via formatCurrency
- All monetary values from the API remain in cents (minor units)
- Conversions happen at display/formatting time using formatCurrency
- Ensures consistency between express checkout, payment forms, and totals display
- Fixed Apple Pay/Google Pay amounts showing incorrect values
- Fixed express checkout totals calculation errors
- Properly handles currency formatting in all payment provider integrations
Files Changed
New Files:
Updated Files:
How to Test
Start the dev server
npm run dev
Expected Behavior
Changeset
Test Plan