Skip to content

fix(fish): honor GO_TASK_PROGNAME for experiments cache #2730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vmaerten merged 2 commits into from
Mar 21, 2026
+2 −2
Merged

fix(fish): honor GO_TASK_PROGNAME for experiments cache #2730

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
159599c
fix(fish): use GO_TASK_PROGNAME for experiments lookup
SergioChan Mar 9, 2026
093f4b6
fix(fish): inherit GO_TASK_PROGNAME in experiments helper
SergioChan Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions completion/fish/task.fish
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ set -g __task_experiments_cache ""
set -g __task_experiments_cache_time 0

# Helper function to get experiments with 1-second cache
function __task_get_experiments
function __task_get_experiments --inherit-variable GO_TASK_PROGNAME
set -l now (date +%s)
set -l ttl 1 # Cache for 1 second only

Expand All @@ -16,7 +16,7 @@ function __task_get_experiments
end

# Refresh cache
set -g __task_experiments_cache (task --experiments 2>/dev/null)
set -g __task_experiments_cache ($GO_TASK_PROGNAME --experiments 2>/dev/null)
set -g __task_experiments_cache_time $now
printf '%s\n' $__task_experiments_cache
end
Expand Down
Loading