Propagate run:once errors to all dependents

internal/flags/flags.go

@@ -44,49 +44,49 @@
 `
 
 var (
-	Version             bool
-	Help                bool
-	Init                bool
-	Completion          string
-	List                bool
-	ListAll             bool
-	ListJson            bool
-	TaskSort            string
-	Status              bool
-	NoStatus            bool
-	Nested              bool
-	Insecure            bool
-	Force               bool
-	ForceAll            bool
-	Watch               bool
-	Verbose             bool
-	Silent              bool
-	DisableFuzzy        bool
-	AssumeYes           bool
-	Dry                 bool
-	Summary             bool
-	ExitCode            bool
-	Parallel            bool
-	Concurrency         int
-	Dir                 string
-	Entrypoint          string
-	Output              ast.Output
-	Color               bool
-	Interval            time.Duration
-	Failfast            bool
-	Global              bool
-	Experiments         bool
-	Download            bool
-	Offline             bool
-	TrustedHosts        []string
-	ClearCache          bool
-	Timeout             time.Duration
-	CacheExpiryDuration time.Duration
-	RemoteCacheDir      string
-	CACert              string
-	Cert                string
-	CertKey             string
-	Interactive         bool
+	Version               bool
+	Help                  bool
+	Init                  bool
+	Completion            string
+	List                  bool
+	ListAll               bool
+	ListJson              bool
+	TaskSort              string
+	Status                bool
+	NoStatus              bool
+	Nested                bool
+	Insecure              bool
+	Force                 bool
+	ForceAll              bool
+	Watch                 bool
+	Verbose               bool
+	Silent                bool
+	DisableFuzzy          bool
+	AssumeYes             bool
+	Dry                   bool
+	Summary               bool
+	ExitCode              bool
+	Parallel              bool
+	Concurrency           int
+	Dir                   string
+	Entrypoint            string
+	Output                ast.Output
+	Color                 bool
+	Interval              time.Duration
+	Failfast              bool
+	Global                bool
+	Experiments           bool
+	Download              bool
+	Offline               bool
+	TrustedHosts          []string
+	ClearCache            bool
+	Timeout               time.Duration
+	CacheExpiryDuration   time.Duration
+	RemoteCacheDir        string
+	CACert                string
+	Cert                  string
+	CertKey               string
+	Interactive           bool
 )
 
 func init() {

task.go

@@ -2,6 +2,7 @@
 
 import (
 	"context"
+	stderrors "errors"
 	"fmt"
 	"os"
 	"runtime"
@@ -25,6 +26,8 @@
 	"github.com/go-task/task/v3/taskfile/ast"
 )
 
+var errSharedExecutionSuccess = stderrors.New("shared execution succeeded")
+
 const (
 	// MaximumTaskCall is the max number of times a task can be called.
 	// This exists to prevent infinite loops on cyclic dependencies
@@ -456,16 +459,28 @@
 		defer reacquire()
 
 		<-otherExecutionCtx.Done()
+
+		if cause := context.Cause(otherExecutionCtx); cause != nil && cause != errSharedExecutionSuccess {
+			return cause
+		}
 		return nil
 	}
 
-	ctx, cancel := context.WithCancel(ctx)
-	defer cancel()
+	ctx, cancel := context.WithCancelCause(ctx)
+	defer func() {
+		if err != nil {
+			cancel(err)
+		} else {
+			cancel(errSharedExecutionSuccess)
+		}
+	}()
 
 	e.executionHashes[h] = ctx
 	e.executionHashesMutex.Unlock()
 
-	return execute(ctx)
+	// Save err in variable so it also applied to the cancel defer
+	err = execute(ctx)
+	return err
 }
 
 // FindMatchingTasks returns a list of tasks that match the given call. A task

task_test.go

@@ -1952,6 +1952,31 @@ func TestRunOnceSharedDeps(t *testing.T) {
 	assert.Contains(t, buff.String(), `task: [service-b:build] echo "build b"`)
 }
 
+func TestRunOnceSharedDepsFail(t *testing.T) {
+	t.Parallel()
+
+	const dir = "testdata/run_once_shared_deps_fail"
+
+	var buff bytes.Buffer
+	e := task.NewExecutor(
+		task.WithDir(dir),
+		task.WithStdout(&buff),
+		task.WithStderr(&buff),
+		task.WithForceAll(true),
+	)
+	require.NoError(t, e.Setup())
+	require.Error(t, e.Run(t.Context(), &task.Call{Task: "build"}))
+
+	// The shared dependency should still only be attempted once.
+	rx := regexp.MustCompile(`task: \[service-[a,b]:library:build\] echo "build library" && exit 1`)
+	matches := rx.FindAllStringSubmatch(buff.String(), -1)
+	assert.Len(t, matches, 1)
+
+	// If the shared dependency fails, both branches must be blocked from running their own commands.
+	assert.NotContains(t, buff.String(), `task: [service-a:build] echo "build a"`)
+	assert.NotContains(t, buff.String(), `task: [service-b:build] echo "build b"`)
+}
+
 func TestRunWhenChanged(t *testing.T) {
 	t.Parallel()
 

testdata/run_once_shared_deps_fail/Taskfile.yml

@@ -0,0 +1,13 @@
+version: '3'
+
+includes:
+  service-a: ./service-a
+  service-b: ./service-b
+
+tasks:
+  build:
+    deps:
+      - service-a:build
+      - service-b:build
+
+

testdata/run_once_shared_deps_fail/library/Taskfile.yml

@@ -0,0 +1,9 @@
+version: '3'
+
+tasks:
+  build:
+    run: once
+    cmds:
+      - echo "build library" && exit 1
+
+

testdata/run_once_shared_deps_fail/service-a/Taskfile.yml

@@ -0,0 +1,15 @@
+version: '3'
+
+includes:
+  library:
+    taskfile: ../library/Taskfile.yml
+    dir: ../library
+
+tasks:
+  build:
+    run: once
+    deps: [library:build]
+    cmds:
+      - echo "build a"
+
+

testdata/run_once_shared_deps_fail/service-b/Taskfile.yml

@@ -0,0 +1,13 @@
+version: '3'
+
+includes:
+  library:
+    taskfile: ../library/Taskfile.yml
+    dir: ../library
+
+tasks:
+  build:
+    run: once
+    deps: [library:build]
+    cmds:
+      - echo "build b"