Fix/enforce internal rules #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Resolves one github gotcha with boolean input parameters. Now workflow parameters are enforced to be strings so we don't have to deal with several ways of evaluating whether something is true or false. Chore: enforced consistent formatting standards for github annotations and expressions. Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
There was a problem hiding this comment.
Pull request overview
This PR enforces internal rules and fixes various inconsistencies across GitHub Actions workflow files. The changes primarily standardize formatting, correct syntax errors, and remove problematic experimental files.
Key changes:
- Fixed spacing inconsistencies in GitHub Actions workflow conditions and expressions
- Standardized input types from
booleantostringfor workflow_dispatch and workflow_call inputs to ensure consistent string-based comparisons - Corrected GitHub Actions notice format syntax by adding missing colons between title and message
- Added spell-check and markdown lint configuration files
- Removed two problematic experimental workflow files that contained syntax errors
Reviewed changes
Copilot reviewed 8 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| experimental/pr-comment.yml | Fixed spacing in conditional expressions and template syntax |
| experimental/local-monorepo-go-test.yml | Removed experimental workflow file |
| experimental/go-test-monorepo.yml | Removed experimental workflow file with multiple syntax errors |
| experimental/.wordlist.txt | Added wordlist for spell-checking |
| experimental/.spellcheck.yml | Added spell-check configuration |
| experimental/.markdownlint.yml | Added markdown linting configuration |
| .github/workflows/local-bump-release.yml | Changed input types from boolean to string for consistency |
| .github/workflows/go-test.yml | Fixed notice format with missing colon separator |
| .github/workflows/fuzz-test.yml | Fixed notice format with missing colon separators |
| .github/workflows/contributors.yml | Changed input type from boolean to string |
| .github/workflows/bump-release.yml | Changed input types to string, fixed notice format, simplified conditional expressions |
| .github/workflows/auto-merge.yml | Changed input type to string, simplified conditional expression |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #57 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 14 14
=========================================
Hits 14 14 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change type
Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update
Short description
Fixes
Full description
Checklist