Skip to content

Conversation

@silverwind
Copy link
Member

@silverwind silverwind commented Dec 13, 2025

  • Update all JS deps
  • Tested affected dependencies
  • Replace eslint unstable_native_nodejs_ts_config with optional jiti dependency. This will be more compatible with editor integrations that may not pass this flag.
  • Enable @typescript-eslint/array-type and autofix issues (I strongly prefer this style)
  • Enable additional eslint rules, no new issues
  • Move typescript to devDependencies because make frontend works without it

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 13, 2025
@silverwind silverwind changed the title Update JS deps and misc tweaks Update JS deps and eslint enhancements Dec 13, 2025
@lunny
Copy link
Member

lunny commented Dec 13, 2025

It seems string[] looks more better than Array<string> in most situation.

@silverwind
Copy link
Member Author

silverwind commented Dec 14, 2025

For simple types maybe but once they get complex, generic form is superior, e.g. Array<Foo | Bar> is more readable than (Foo | Bar)[]. And once you start using generic syntax, you question why there are two syntax variants in use so I just like to default to one syntax. There is a array-simple option too but I find it unsuitable because I don't want to forbid generic syntax for simple types.

It's not a big issue for me, if people prefer the [] (maybe because they come from go), we can continue to allow both syntaxes. I will only be writing generic syntax though.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/dependencies modifies/frontend modifies/internal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants