Refactor FileTreeItem type
#36137
Merged
Refactor FileTreeItem type
#36137
+15
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
silverwind
added
the
skip-changelog
wxiaoguang
reviewed
Dec 12, 2025
silverwind
changed the title
tsc / tsgo output cleantsgo to lint non-vue files
delvh
approved these changes
Dec 12, 2025
GiteaBot
added
lgtm/need 1
Contributor
If the existing lint covers all the cases of |
Member
Author
|
That issue likely won't be resolved anytime soon, at least not cleanly. We can remove the tsgo dependency if you like, it does not affect me, I can still run tsgo even without it being a dependency. |
Member
Author
|
removed tsgo, now this is just a refactor. |
wxiaoguang
approved these changes
Dec 13, 2025
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Dec 15, 2025
* giteaofficial/main: Remove undocumented support of signing key in the repository git configuration file (go-gitea#36143) Enable gocheckcompilerdirectives linter (go-gitea#36156) Fix code highlighting on blame page (go-gitea#36157) Check user visibility when redirecting to a renamed user (go-gitea#36148) Fix bug when viewing the commit diff page with non-ANSI files (go-gitea#36149) Refactor `FileTreeItem` type (go-gitea#36137) Fix various bugs (go-gitea#36139) Fix issue close timeline icon (go-gitea#36138) Add permissions to`files-changed` jobs (go-gitea#36142) Add explicit permissions to all actions workflows (go-gitea#36140) Bump `actions/checkout` to v6 (go-gitea#36136) Hide RSS icon when viewing a file not under a branch (go-gitea#36135) Fix SVG size calulation, only use `style` attribute (go-gitea#36133) Add sorting/filtering to admin user search API endpoint (go-gitea#36112)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add and enable
tsgoto lint non-vue files.tsgois not aware of exports from.vuefiles, but these are rare so we declare them inglobals.d.ts. The primary use case is runningpnpm exec tsgoon the CLI to quickly validate non-vue changes (tsgo is about 6 times faster).This change also enables VSCode
typescript.experimental.useTsgoto work without errors in non-vue files.make lint-jswill lint non-vue files twice currently and this can not be avoided until vuejs/language-tools#5381 is resolved, but it's acceptable imho.