removed pinned from v2 bookmarks#1392
Merged
Merged
Conversation
aaschaer
requested review from
MaxTueckeGlobus,
ada-globus,
derek-globus,
kurtmckee,
m1yag1 and
sirosen
as code owners
kurtmckee
requested changes
Jun 5, 2026
kurtmckee
left a comment
kurtmckee
left a comment
Member
There was a problem hiding this comment.
I think it'll be appropriate to have a changelog fragment for this, though it sounds like it's provable that it hasn't been in use.
Contributor
Author
|
@kurtmckee I've added a changelog fragment |
aaschaer
force-pushed
the
aaron/remove_pinned
branch
from
c3f8a01 to
5cc7aad
Compare
kurtmckee
approved these changes
Jun 5, 2026
pjhinton-globus
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We made a somewhat late decision to pull
pinnedfrom bookmarks v2 as it was unused in v1 since 2024.I'm marking this no-news-is-good-news since its removing a nonexistant field, but lmk if I should actually add a changelog