Skip to content

Fix: use builtin dataclasses.fields instead of __annotations__ #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
purarue wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: use builtin dataclasses.fields instead of __annotations__ #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions trakt/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
__author__ = 'Elan Ruusamäe'

import json
from dataclasses import dataclass
from dataclasses import dataclass, fields
from os.path import exists
from typing import Optional

Expand Down Expand Up @@ -40,7 +40,8 @@ def update(self, **kwargs):

def all(self):
result = {}
for key in self.__annotations__.keys():
for field in fields(self):
key = field.name
result[key] = self.get(key)

return result
Expand All @@ -55,7 +56,8 @@ def load(self):
with open(self.config_path) as config_file:
config_data = json.load(config_file)

for key in self.__annotations__.keys():
for field in fields(self):
key = field.name
# Don't overwrite
if self.get(key) is not None:
continue
Expand Down