Skip to content

Refactor: Avoid duplicate calls to e.response.json() #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
glensc wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Refactor: Avoid duplicate calls to e.response.json() #93

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c2468a
Avoid duplicate calls to e.response.json()
glensc Sep 8, 2025
777f45d
Auto-format api.py imports
glensc Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions trakt/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@
from trakt import errors
from trakt.config import AuthConfig
from trakt.core import TIMEOUT
from trakt.errors import BadRequestException, BadResponseException, OAuthException
from trakt.errors import (BadRequestException, BadResponseException,
OAuthException)

__author__ = 'Elan Ruusamäe'

Expand Down Expand Up @@ -256,8 +257,9 @@ def refresh_token(self):
except (OAuthException, BadRequestException) as e:
if e.response is not None:
try:
error = e.response.json().get("error")
error_description = e.response.json().get("error_description")
data = e.response.json()
error = data.get("error")
error_description = data.get("error_description")
except JSONDecodeError:
error = "Invalid JSON response"
error_description = e.response.text
Expand Down