Ci: Use sphinx from pip

[glensc]

Take recommendations from coderabbit to accoiunt:

• CI: Add job to test docs build #12

[coderabbitai]

Walkthrough

The pull request modifies two GitHub Actions workflow files related to documentation: docs-build.yml and docs-upload.yml. The changes focus on improving the dependency installation and documentation build processes by separating installation steps, adding explicit pip upgrades, and specifying a minimum sphinx version of 7.1.0. These modifications aim to enhance the clarity and robustness of the documentation generation workflow.

Changes

File	Change Summary
.github/workflows/docs-build.yml	- Separated dependency installation and documentation build steps - Added pip upgrade command - Specified sphinx minimum version 7.1.0
.github/workflows/docs-upload.yml	- Added set -eux for debugging and error handling - Updated version writing method using tee - Restructured dependency installation - Added pip upgrade - Specified sphinx minimum version 7.1.0

Possibly related PRs

• CI: Add job to test docs build #12: Introduces a new job testing the documentation build process, which aligns with the modifications to the .github/workflows/docs-build.yml file in this PR.

Poem

🐰 Workflows dancing, steps so bright,
Pip upgraded with rabbit might!
Sphinx version set just right,
Documentation builds take flight,
Code's magic unfurls in pure delight! 🚀

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

.github/workflows/docs-build.yml (1)

44-44: Consider adding error handling for the docs build step.

While version setup has error handling, the make docs command could benefit from similar treatment.

-          make docs
+          make docs || exit 1

.github/workflows/docs-upload.yml (1)

54-59: Consider maintaining consistency between workflows.

While these changes match the docs-build.yml improvements, consider adding the same error handling improvements (set -eux) to docs-build.yml for consistency.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b2a2f3e and a5b5b12.

📒 Files selected for processing (2)

• .github/workflows/docs-build.yml (1 hunks)
• .github/workflows/docs-upload.yml (1 hunks)

🔇 Additional comments (3)

.github/workflows/docs-build.yml (1)

39-42: LGTM! Clear separation of dependency installation steps.

The explicit pip upgrade and version constraint for sphinx are good practices. This ensures consistent builds with up-to-date package management tools.

.github/workflows/docs-upload.yml (2)

47-48: Great addition of strict error handling!

The set -eux addition improves debugging capabilities and ensures strict error handling.

---

51-51: Good improvement using tee for version file writing.

Using tee provides better visibility of the version being written to the file.