Skip to content

Fix ids setter for Person and TVEpisode #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glensc merged 2 commits into from
Dec 11, 2022
Merged

Fix ids setter for Person and TVEpisode #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eda137a
Add test for People.ids
glensc Dec 11, 2022
c99f38f
Add ids setter
glensc Dec 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tests/test_shows.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,14 @@ def test_get_people():
for group in groups:
assert all([isinstance(p, Person) for p in group])

ids = {
'imdb': 'nm0227759',
'slug': 'peter-dinklage',
'tmdb': 22970,
'trakt': 639,
}
assert got.people[0].ids['ids'] == ids


def test_ratings():
got = TVShow('Game of Thrones')
Expand Down
4 changes: 4 additions & 0 deletions trakt/mixins.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ def ids(self):
'ids': ids
}

@ids.setter
def ids(self, value):
self._ids = value

@property
def imdb(self):
return self._ids.get('imdb', None)
Expand Down