feat!: support hashicorp/helm provider 3.x#12
Open
KOCEAN33 wants to merge 1 commit into
Open
Conversation
The helm provider 3.0 migrated to the Terraform Plugin Framework. Nested blocks were replaced by list/object attributes in both the `helm_release` resource and the provider configuration. This module still used the legacy block form and was incompatible with helm >= 3.0 (refs gitops-bridge-dev#7). Changes: - main.tf: convert `set`, `set_sensitive`, and `postrender` from `dynamic` blocks to the attribute form (`set = [...]`, `postrender = {...}`). The values pass through from `var.argocd`, so the public input shape for the `argocd` variable is unchanged. - versions.tf: raise the helm provider floor to `>= 3.0.0`. - tests/complete: update the `provider "helm"` block to the v3 attribute form (`kubernetes = { ... }`) and drop the unused, undeclared `provider "kubectl"` block that blocked `terraform init`. BREAKING CHANGE: requires the helm provider >= 3.0.0. Consumers still on helm 2.x must stay on the 0.1.x line (see the < 3.0.0 cap in gitops-bridge-dev#11). Verified with `terraform validate` against helm 3.2.0 for both the root module and tests/complete. Signed-off-by: kocean33 <dev@xanny.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrate the module to the
hashicorp/helmprovider3.xAPI.Why
helm provider
3.0adopted the Terraform Plugin Framework and replaced the nested blocks with list/object attributes, in both thehelm_releaseresource and the provider configuration. This module used the legacydynamic "set"/dynamic "postrender"block form, so it does not work with helm>= 3.0. Closes #7.Changes
main.tf— convertset,set_sensitive,postrenderfromdynamicblocks to the attribute form:var.argocd, so the publicargocdinput shape is unchanged for callers already supplyingset = [{ name, value }].versions.tf— raise the helm provider floor to>= 3.0.0.tests/complete— updateprovider "helm"to the v3 attribute form (kubernetes = { ... }) and remove the unused, undeclaredprovider "kubectl"block that blockedterraform init.README.md— regenerated provider/requirement version.Breaking change
Requires helm provider
>= 3.0.0. Consumers still on helm 2.x should stay on the0.1.xline — see the< 3.0.0cap in #11. Suggest releasing this as0.2.0.Verification
DCO: commit signed off via
git commit -s.