Support add_labels / remove_labels in update Merge Request#1323
Open
mhagnumdw wants to merge 1 commit into
Open
Support add_labels / remove_labels in update Merge Request#1323mhagnumdw wants to merge 1 commit into
mhagnumdw wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
withAddLabels(...)andwithRemoveLabels(...)toMergeRequestParams, mapping to theadd_labelsandremove_labelsform parameters of the GitLab Update Merge Request endpoint: https://docs.gitlab.com/api/merge_requests/#update-a-merge-requestMotivation
Currently
MergeRequestParamsonly exposeswithLabels(...), which sends the fulllabelslist and replaces the merge request's labels entirely. Adding or removing a single label therefore requires fetching the current label set and re-sending it.The GitLab API already supports incremental label changes via
add_labelsandremove_labelsonly on the update endpoint: https://docs.gitlab.com/api/merge_requests/#update-a-merge-requestChanges
MergeRequestParams: two new fields (addLabels,removeLabels) and serialization wired into the update-only branch ofgetForm(boolean isCreate)TestMergeRequestParams: add some testsThe change is strictly additive - existing behavior of
withLabels(...)is unchanged.Usage
ps: I'm already using these changes in my application and everything is fine.