Fixed Undock Button getting hidden after undocking and docking again …#816
Open
alessandrohj wants to merge 1 commit intogithubuser0xFFFF:masterfrom
Open
Fixed Undock Button getting hidden after undocking and docking again …#816alessandrohj wants to merge 1 commit intogithubuser0xFFFF:masterfrom
alessandrohj wants to merge 1 commit intogithubuser0xFFFF:masterfrom
Conversation
…a floating widget that contains only one single visble dock area
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where if the user drops a floating widget that contains only one single visible dock area, the Undock Button present in the title bar gets hidden and it never shows up again until the application is closed/reopened.
There's a comment in the code mentioning the need to make it show up again. So it's probably just a small miss.
This bug is not visible in the Demo application or on applications that have the Auto Hide Feature enabled.
With that feature enabled,
updateTitleBarButtonVisibilitygets called. And this function "hides" the bug since it makes all buttons show up again: