Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 27, 2026

Changes Addressing Feedback

Updated approach per @pelikhan's feedback: Instead of failing the conclusion job when no safe outputs exist, the information is now included in the failure tracking issue/comment.

Changes Made:

  • Modified handle_agent_failure.cjs to detect when agent succeeds but produces no safe outputs
  • Added missing safe outputs context to failure issue/comment templates
  • Removed the "Determine if conclusion job should fail" step from conclusion job
  • Updated tests to cover new behavior (agent success with/without safe outputs)
  • Recompiled all workflows
  • Removed unused determine_conclusion_failure.cjs and test file

Behavior:

When agent succeeds but produces no safe outputs:

  • Creates/updates failure tracking issue with warning about missing outputs
  • Does NOT fail the conclusion job
  • Explains possible causes (safe output server failure, prompt failure, missing noop call)

When agent succeeds with safe outputs:

  • Skips failure handling (normal behavior)
  • Conclusion job completes successfully
Original prompt

Update the JavaScript that decide to report a failure in the conclusion job to report workflow run without any safe output entries as failures. Typically this means that the safe output server failed to run or that the prompt completely failed to generate any kind of meaningful result and it should have called "noop".


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits January 27, 2026 16:00
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Update JavaScript for reporting workflow run failures Fail conclusion job when workflow produces no safe outputs Jan 27, 2026
Copilot AI requested a review from pelikhan January 27, 2026 16:14
@pelikhan
Copy link
Contributor

@copilot do not fail the conclusion, instead add this information in the action failed issue/comment created in the conclusion job.

…usion job

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 27, 2026

@copilot do not fail the conclusion, instead add this information in the action failed issue/comment created in the conclusion job.

Updated in commit 7babd57. Instead of failing the conclusion job, the missing safe outputs information is now included in the failure tracking issue/comment created by handle_agent_failure.cjs.

The behavior now:

  • When agent succeeds but produces no safe outputs → creates/updates failure issue with warning
  • When agent succeeds with safe outputs → skips failure handling (normal flow)
  • Conclusion job never fails due to missing safe outputs

Copilot AI changed the title Fail conclusion job when workflow produces no safe outputs Report missing safe outputs in failure issue instead of failing conclusion job Jan 27, 2026
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI requested a review from pelikhan January 27, 2026 17:07
@pelikhan pelikhan marked this pull request as ready for review January 27, 2026 18:07
@pelikhan pelikhan merged commit 88b14a1 into main Jan 27, 2026
49 checks passed
@pelikhan pelikhan deleted the copilot/update-conclusion-job-reporting branch January 27, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants