-
Notifications
You must be signed in to change notification settings - Fork 37
Report missing safe outputs in failure issue instead of failing conclusion job #12047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot do not fail the conclusion, instead add this information in the action failed issue/comment created in the conclusion job. |
…usion job Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Updated in commit 7babd57. Instead of failing the conclusion job, the missing safe outputs information is now included in the failure tracking issue/comment created by The behavior now:
|
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Changes Addressing Feedback
Updated approach per @pelikhan's feedback: Instead of failing the conclusion job when no safe outputs exist, the information is now included in the failure tracking issue/comment.
Changes Made:
handle_agent_failure.cjsto detect when agent succeeds but produces no safe outputsdetermine_conclusion_failure.cjsand test fileBehavior:
When agent succeeds but produces no safe outputs:
When agent succeeds with safe outputs:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.