-
Notifications
You must be signed in to change notification settings - Fork 37
Expand hostedtoolcache PATH integration for Python and other runtimes #11979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
- Create shared GetHostedToolcachePathSetup() helper in engine_helpers.go - Update claude_engine.go to use unified PATH setup (not just Node.js) - Update codex_engine.go to use unified PATH setup (not just Node.js) - Update copilot_engine_execution.go to use shared helper for consistency - Add tests for GetHostedToolcachePathSetup in engine_helpers_test.go The new PATH setup finds all bin directories in /opt/hostedtoolcache, making Python, Go, Ruby, and other runtimes accessible in agent containers. Fixes #12033 Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
…toolcache-path # Conflicts: # .github/workflows/jsweep.lock.yml # .github/workflows/smoke-claude.lock.yml # .github/workflows/smoke-codex.lock.yml # .github/workflows/smoke-copilot.lock.yml
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
🌑 The shadows whisper... Smoke Codex was cancelled. The oracle requires further meditation... |
|
💀 Blimey! Changeset Generator was cancelled and walked the plank! No treasure today, matey! ☠️ |
|
💫 TO BE CONTINUED... Smoke Claude was cancelled! Our hero faces unexpected challenges... |
|
📰 DEVELOPING STORY: Smoke Copilot reports was cancelled. Our correspondents are investigating the incident... |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
|
🎭 The Copilot smoke test agent just breezed through town! 🌪️ All systems are running smooth as silk – GitHub MCP queries are flowing, Serena's activated, Playwright's dancing through web pages, and files are being written and read like poetry. The smoke test agent was here, it conquered, and now it's off to smoke-test another day! 💨✨ Stay awesome, gh-aw team! 🚀 Smoke test run: §21407113629
|
Smoke Test Results ✅Last 2 Merged PRs:
Test Results:
Overall Status: PASS ✅ cc @Mossaka
|
|
GitHub MCP merged PRs: ✅ Fix AWF command quoting to ensure agent runs inside firewall container; ✅ Add
|
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
Smoke Test: Claude - 21407113647Last 2 Merged PRs:
Test Results: Status: PASS ✅
|
The PATH setup for agent containers only exposed Node.js binaries from
/opt/hostedtoolcache. Claude and Codex engines used a Node-specific find command while Copilot already used a more general approach.Changes
GetHostedToolcachePathSetup()inengine_helpers.goreturning a unified PATH setup commandPATH Setup
Before (Claude/Codex - Node only):
After (all engines - all runtimes):
This adds all runtime binaries to PATH matching the hostedtoolcache structure:
/opt/hostedtoolcache/<tool>/<version>/<arch>/bin(node, Python, go, Ruby, etc.).Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
Changeset