Skip to content

Address sourcemap.test.ts flakiness #4274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cklin wants to merge 1 commit into from
Closed

Address sourcemap.test.ts flakiness #4274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions extensions/ql-vscode/test/vscode-tests/cli-integration/sourcemap.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,21 @@ import { tmpDir } from "../../../src/tmp-dir";
import { readFile, writeFile, ensureDir, copy } from "fs-extra";
import { createVSCodeCommandManager } from "../../../src/common/vscode/commands";
import type { AllCommands } from "../../../src/common/commands";
import { getActivatedExtension } from "../global.helper";

/**
* Integration tests for queries
*/
describe("SourceMap", () => {
const commandManager = createVSCodeCommandManager<AllCommands>();

beforeEach(async () => {
// Ensure that the extension is fully activated before running tests. This is important
// because the extension activate() function ensures that the language server is up and
// running before returning, so that we don't get "Client is not running" test flakes.
await getActivatedExtension();
});
Comment on lines +15 to +20
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This suite already activates the CodeQL extension via the CLI integration Jest setup (extensions/ql-vscode/test/vscode-tests/cli-integration/jest.setup.ts calls beforeAllAction(), which calls getActivatedExtension() in jest.activated-extension.setup.ts). Adding another getActivatedExtension() here is therefore redundant and can be misleading when diagnosing the flake. Consider removing this hook, switching it to beforeAll, or moving any required readiness/wait logic into the shared setup so all tests benefit consistently.

Copilot uses AI. Check for mistakes.

it("should jump to QL code", async () => {
const root = workspace.workspaceFolders![0].uri.fsPath;
const srcFiles = {
Expand Down
Loading