Creating secret.yml for github-well-architected#51
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Zenulous
approved these changes
Mar 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a production secrets.yml manifest for the github-well-architected service so Moda/Vault-backed secret metadata is available for deployments and auditing.
Changes:
- Introduces
config/moda/secrets/production/secrets.ymlwith secret metadata entries. - Defines production entries for Copilot-related URLs and an HMAC key (owner, type, kind, etc.).
Comments suppressed due to low confidence (1)
config/moda/secrets/production/secrets.yml:23
playbook:is specified without a value (YAMLnull). To keep the schema consistent with other environments (e.g.,stagingusesplaybook: ''), set this to an empty string or omit the key when there is no playbook.
type: config
owner: "@github/customer-success-engineering"
playbook:
externally_usable: false
kind: latest_at_deployment_start
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+5
to
+9
| type: config | ||
| owner: "@github/customer-success-engineering" | ||
| playbook: | ||
| externally_usable: false | ||
| kind: latest_at_deployment_start |
Comment on lines
+24
to
+30
| kittens: | ||
| key: kittens | ||
| type: kittens | ||
| owner: '' | ||
| playbook: | ||
| externally_usable: false | ||
| kind: latest_at_deployment_start |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was automatically generated from
vault-chatops.It contains the secrets.yml file for
github-well-architectedinproduction.More info about this file can be found here
Please review these files and add missing information if possible.
These are the most important keys in the secrets.yml file:
key
This specifies the key in vault if it's not the same as the key for this secret
type
The type of secret. This is used to determine how the secret is used in the application.
Some secrets are just configuration. In that case the type is
configand the keysowner,playbookandexternally_usablecan be left out.For values like usernames that are used to authenticate, but are not a secret, the type
credentialsshould be used.A list of available types can be found here
owner
Which team owns the usage of the secret, not the central management service. If you are part of the sae-ps team, and the secret is a database credential your team uses, then you put in
@github/sae-psplaybook
Is there a playbook for rotating this secret? If so, please provide a link to it.
externally_usable
If this secret is leaked can it be used without GitHub network access? (like a GitHub PAT)
kind
This should probably be set to
latest_at_deployment_start.