Skip to content

Creating secret.yml for github-well-architected#51

Merged
Zenulous merged 1 commit intomainfrom
generate-secret-yml-github-well-architected-production
Mar 17, 2026
Merged

Creating secret.yml for github-well-architected#51
Zenulous merged 1 commit intomainfrom
generate-secret-yml-github-well-architected-production

Conversation

@vault-chatops
Copy link
Contributor

@vault-chatops vault-chatops bot commented Mar 17, 2026

This pull request was automatically generated from vault-chatops.
It contains the secrets.yml file for github-well-architected in production.

More info about this file can be found here

Please review these files and add missing information if possible.

These are the most important keys in the secrets.yml file:

key

This specifies the key in vault if it's not the same as the key for this secret

type

The type of secret. This is used to determine how the secret is used in the application.
Some secrets are just configuration. In that case the type is config and the keys owner, playbook and externally_usable can be left out.
For values like usernames that are used to authenticate, but are not a secret, the type credentials should be used.
A list of available types can be found here

owner

Which team owns the usage of the secret, not the central management service. If you are part of the sae-ps team, and the secret is a database credential your team uses, then you put in @github/sae-ps

playbook

Is there a playbook for rotating this secret? If so, please provide a link to it.

externally_usable

If this secret is leaked can it be used without GitHub network access? (like a GitHub PAT)

kind

This should probably be set to latest_at_deployment_start.

@github-actions github-actions bot added the draft PR is in draft label Mar 17, 2026
@github-actions
Copy link

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@Zenulous Zenulous marked this pull request as ready for review March 17, 2026 16:18
@Zenulous Zenulous requested review from a team as code owners March 17, 2026 16:18
Copilot AI review requested due to automatic review settings March 17, 2026 16:18
@github-actions github-actions bot added ready for review and removed draft PR is in draft labels Mar 17, 2026
@Zenulous Zenulous marked this pull request as draft March 17, 2026 16:19
@Zenulous Zenulous marked this pull request as ready for review March 17, 2026 16:19
@github-actions github-actions bot added draft PR is in draft and removed ready for review labels Mar 17, 2026
@github-actions github-actions bot added ready for review and removed draft PR is in draft labels Mar 17, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a production secrets.yml manifest for the github-well-architected service so Moda/Vault-backed secret metadata is available for deployments and auditing.

Changes:

  • Introduces config/moda/secrets/production/secrets.yml with secret metadata entries.
  • Defines production entries for Copilot-related URLs and an HMAC key (owner, type, kind, etc.).
Comments suppressed due to low confidence (1)

config/moda/secrets/production/secrets.yml:23

  • playbook: is specified without a value (YAML null). To keep the schema consistent with other environments (e.g., staging uses playbook: ''), set this to an empty string or omit the key when there is no playbook.
    type: config
    owner: "@github/customer-success-engineering"
    playbook:
    externally_usable: false
    kind: latest_at_deployment_start

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment on lines +5 to +9
type: config
owner: "@github/customer-success-engineering"
playbook:
externally_usable: false
kind: latest_at_deployment_start
Comment on lines +24 to +30
kittens:
key: kittens
type: kittens
owner: ''
playbook:
externally_usable: false
kind: latest_at_deployment_start
@Zenulous Zenulous merged commit d06148b into main Mar 17, 2026
29 of 30 checks passed
@Zenulous Zenulous deleted the generate-secret-yml-github-well-architected-production branch March 17, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants