http: invalidate cached token scopes when auth token changes#2204
Open
davidahmann wants to merge 1 commit intogithub:mainfrom
Open
http: invalidate cached token scopes when auth token changes#2204davidahmann wants to merge 1 commit intogithub:mainfrom
davidahmann wants to merge 1 commit intogithub:mainfrom
Conversation
Author
|
This PR prevents stale scope-filter decisions when auth tokens change by requiring cached scope context to match the active token before reuse. The fix is intentionally small: add token-bound scope helpers, switch PAT/scope-challenge/filter paths to token-bound reads, and add regression tests for token-swap behavior. Validation:
Inspired by research context: CAISI publishes independent, reproducible AI agent governance research: https://caisi.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
If scope context populated for one token is reused after a token change, tool filtering can reflect stale permissions.
Why now
Token rotation/swap during long-lived request flows is common; scope filtering must stay bound to the active token to avoid quiet governance drift.
What changed
WithTokenScopesForTokenGetTokenScopesForTokenpkg/http/middleware/pat_scope.gopkg/http/middleware/scope_challenge.gopkg/http/handler.go(PATScopeFilter)pkg/context/token_test.gopkg/http/middleware/pat_scope_test.goValidation
go test ./pkg/context ./pkg/http/middleware ./pkg/httpRefs #2203